Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to work with latest VS Code go debugger #18397

Merged
merged 1 commit into from
Jan 25, 2022
Merged

Update to work with latest VS Code go debugger #18397

merged 1 commit into from
Jan 25, 2022

Conversation

lafriks
Copy link
Member

@lafriks lafriks commented Jan 24, 2022

Fixes #18394

@lafriks lafriks added the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label Jan 24, 2022
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Jan 24, 2022
@zeripath
Copy link
Contributor

zeripath commented Jan 24, 2022 •
edited
Loading

actually hang a sec I think we need the cwd. no ignore me!

@zeripath
Copy link
Contributor

make lgtm work

@zeripath zeripath added the type/docs This PR mainly updates/creates documentation label Jan 24, 2022
@zeripath zeripath added this to the 1.17.0 milestone Jan 24, 2022
@silverwind
Copy link
Member

I'm not a vscode user, but I wonder if this config could be put into a .vscode directory in the repo root so it's automatically picked up.

@lunny
Copy link
Member

lunny commented Jan 25, 2022

I'm not a vscode user, but I wonder if this config could be put into a .vscode directory in the repo root so it's automatically picked up.

It could but different developers may want different settings and launch configurations. So I think it's better to still keep it in crontrib directory.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 25, 2022
@zeripath zeripath merged commit 9628a76 into go-gitea:main Jan 25, 2022
@lafriks lafriks deleted the feat/update_vscode_launch branch January 25, 2022 05:25
zjjhot added a commit to zjjhot/gitea that referenced this pull request Jan 25, 2022
@zjjhot
Merge remote-tracking branch 'giteaoffical/main'
0579c7b 
* giteaoffical/main:
  Place inline diff comment dialogs on split diff in 4th and 8th columns (go-gitea#18403)
  API: Return primary language and repository language stats API URL (go-gitea#18396)
  Update to work with latest VS Code go debugger (go-gitea#18397)
  Fix restore without topic failure (go-gitea#18387)
  [skip ci] Updated translations via Crowdin
  Make WrappedQueues and PersistableChannelUniqueQueues Pausable (go-gitea#18393)
  Fix commit's time (go-gitea#18375)
  Prevent showing webauthn error for every time visiting `/user/settings/security` (go-gitea#18385)
Chianina pushed a commit to Chianina/gitea that referenced this pull request Mar 28, 2022
@lafriks
Update to work with latest VS Code go debugger (go-gitea#18397)
6e7f262
@go-gitea go-gitea locked and limited conversation to collaborators Apr 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wxiaoguang wxiaoguang wxiaoguang approved these changes

@zeripath zeripath zeripath approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/docs This PR mainly updates/creates documentation
Projects
None yet
Milestone
1.17.0
Development

Successfully merging this pull request may close these issues.

Cannot debug gitea in vscodium + default vscode-go 0.30.0 config
6 participants
@lafriks @zeripath @silverwind @lunny @wxiaoguang @GiteaBot