Wrap too long push mirror addresses #21120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
delvh
reviewed
Sep 9, 2022
GiteaBot
added
the
lgtm/need 2
|
IMO word-breaking could be better for such case. If you truncate the address, you won't be able to read it / copy it fully. With word-breaking, you get a multiple-line field on the UI and can see the full address. |
|
#21251 could be an example, it fixes the long texts in container table. |
pull-request-size
bot
added
the
size/XS
wxiaoguang
approved these changes
Apr 24, 2023
GiteaBot
added
lgtm/need 1
delvh
changed the title
delvh
approved these changes
Apr 24, 2023
GiteaBot
added
lgtm/done
delvh
added
the
reviewed/wait-merge
GiteaBot
removed
the
reviewed/wait-merge
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Apr 25, 2023
* giteaofficial/main: default show closed actions list if all actions was closed (go-gitea#24234) [skip ci] Updated translations via Crowdin update nightly drone docker tag (go-gitea#24311) Remove org users who belong to no teams (go-gitea#24247) Fix typo in API route (go-gitea#24310) Add --font-weight-bold and set previous bold to 601 (go-gitea#24307) Mark `/templates/swagger/v1_json.tmpl` as generated file (go-gitea#24306) Improve External Wiki in Repo Header (go-gitea#24304) Unify nightly naming across binaries and docker images (go-gitea#24116) Wrap too long push mirror addresses (go-gitea#21120)
wxiaoguang
added
the
outdated/backport/v1.19
GiteaBot
pushed a commit
to GiteaBot/gitea
that referenced
this pull request
Apr 25, 2023
I noticed that it is possible to break the push mirror list by entering a too long URL. This should fix it. | Before | After | |--------------|-----------| |||
silverwind
pushed a commit
that referenced
this pull request
Apr 25, 2023
Backport #21120 by @JakobDev I noticed that it is possible to break the push mirror list by entering a too long URL. This should fix it. | Before | After | |--------------|-----------| ||| Co-authored-by: JakobDev <jakobdev@gmx.de>
|](https://user-images.githubusercontent.com/15185051/189294585-333965d1-0f0f-48e2-96d5-e04b84b55ae3.png)||){kind=link}
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that it is possible to break the push mirror list by entering a too long URL. This should fix it.