Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify nightly naming across binaries and docker images #24116

Merged
merged 4 commits into from
Apr 24, 2023

Conversation

techknowlogick
Copy link
Member

Proposal found here: #23654

TODO: make non-breaking (can we publish docker image using dev and nightly prefix? at same time). if anyone has advice please comment :)

If this PR is merged, then I can add redirects to the downloads site.

@techknowlogick techknowlogick added type/enhancement An improvement of existing functionality type/proposal The new feature has not been accepted yet but needs to be discussed first. outdated/backport/v1.19 This PR should be backported to Gitea 1.19 labels Apr 13, 2023
@techknowlogick techknowlogick added this to the 1.20.0 milestone Apr 13, 2023
Makefile Outdated Show resolved Hide resolved
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Apr 14, 2023
@6543
Copy link
Member

6543 commented Apr 14, 2023

can we publish docker image using dev and nightly prefix? at same time

Well yes ... it just depend how complex our docker manifest build step is going to get

@wxiaoguang
Copy link
Contributor

wxiaoguang commented Apr 14, 2023

I would propose to drop the -dev suffix. Because the -dev tags are not the latest , they are just the starting point of a branch:

I do not think it make senses to continue using the -dev suffix.

And I think almost all edge version users have the ability to fix their deployed image names. Even if they don't change, there is no hurt, until they find that they need the nightly, then change.

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Apr 22, 2023
@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Apr 23, 2023
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 23, 2023
@jolheiser jolheiser added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Apr 24, 2023
@lunny lunny merged commit 017a156 into go-gitea:main Apr 24, 2023
GiteaBot pushed a commit to GiteaBot/gitea that referenced this pull request Apr 24, 2023
Proposal found here: go-gitea#23654

TODO: make non-breaking (can we publish docker image using dev and
nightly prefix? at same time). if anyone has advice please comment :)

If this PR is merged, then I can add redirects to the downloads site.
@GiteaBot GiteaBot added backport/done All backports for this PR have been created and removed reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. labels Apr 24, 2023
silverwind pushed a commit that referenced this pull request Apr 24, 2023
Backport #24116 by @techknowlogick

Proposal found here: #23654

TODO: make non-breaking (can we publish docker image using dev and
nightly prefix? at same time). if anyone has advice please comment :)

If this PR is merged, then I can add redirects to the downloads site.

Co-authored-by: techknowlogick <techknowlogick@gitea.io>
zjjhot added a commit to zjjhot/gitea that referenced this pull request Apr 25, 2023
* giteaofficial/main:
  default show closed actions list if all actions was closed (go-gitea#24234)
  [skip ci] Updated translations via Crowdin
  update nightly drone docker tag (go-gitea#24311)
  Remove org users who belong to no teams (go-gitea#24247)
  Fix typo in API route (go-gitea#24310)
  Add --font-weight-bold and set previous bold to 601 (go-gitea#24307)
  Mark `/templates/swagger/v1_json.tmpl` as generated file (go-gitea#24306)
  Improve External Wiki in Repo Header (go-gitea#24304)
  Unify nightly naming across binaries and docker images (go-gitea#24116)
  Wrap too long push mirror addresses (go-gitea#21120)
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Jul 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. outdated/backport/v1.19 This PR should be backported to Gitea 1.19 size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/enhancement An improvement of existing functionality type/proposal The new feature has not been accepted yet but needs to be discussed first.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants