Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable auto tag to prepare next 1.17 release #22180

Merged
merged 2 commits into from
Dec 20, 2022
Merged

Disable auto tag to prepare next 1.17 release #22180

merged 2 commits into from
Dec 20, 2022

Conversation

lunny
Copy link
Member

@lunny lunny commented Dec 20, 2022

Disable auto tag so that 1.17 release will not tag :1.

6543 and others added 2 commits December 20, 2022 17:45
@6543 @lunny
CI: disable auto_tag (go-gitea#20062)
977ed7e
@zeripath @lunny
Ensure that drone tags 1.16.x and 1.16 on push to v1.16.x tag (go-git…
4bf4410 
…ea#20304)

We need pushes to v1.16.9 to create tags to 1.16.9 and 1.16 but not 1 or latest.

We have previously adjusted the manifest to remove the latest tag, and have removed
auto_tags so that 1 does not get tagged but in doing so we also stopped 1.16 being
tagged. So here we just state the that we tag x.yy in addition to x.yyz*.

Signed-off-by: Andrew Thornton <art27@cantab.net>
@lunny lunny added the topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile label Dec 20, 2022
@lunny lunny added this to the 1.17.4 milestone Dec 20, 2022
delvh
delvh approved these changes Dec 20, 2022
View reviewed changes
Copy link
Member

@delvh delvh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm definitely curious if we'll ever fix that bug completely…

@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Dec 20, 2022
@lunny
Copy link
Member Author

lunny commented Dec 20, 2022

I'm definitely curious if we'll ever fix that bug completely…

I have sent a PR https://gitea.com/gitea/drone-docker/pulls/2 but with less review.

silverwind
silverwind approved these changes Dec 20, 2022
View reviewed changes
Copy link
Member

@silverwind silverwind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this is just a temporary workaround, you could push it, release, revert, without the review process getting in the way.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Dec 20, 2022
@jolheiser jolheiser merged commit 3d34cda into go-gitea:release/v1.17 Dec 20, 2022
@lunny lunny deleted the lunny/disable_auto_tag branch February 6, 2023 03:22
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@silverwind silverwind silverwind approved these changes

@delvh delvh delvh approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile
Projects
None yet
Milestone
1.17.4
Development

Successfully merging this pull request may close these issues.
7 participants
@lunny @silverwind @delvh @GiteaBot @jolheiser @6543 @zeripath