Fix JS NPE when viewing specific range of PR commits #27912
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the easiest fix. While other solutions might be possible, they will not be as trivial.
delvh
added
type/bug
topic/ui-interaction
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/XS
silverwind
reviewed
Nov 5, 2023
|
NPE surely isn't the right term? JavaScript does not have pointers 😆 |
silverwind
approved these changes
Nov 5, 2023
GiteaBot
added
lgtm/need 1
|
Technically, JS calls it |
|
Update: Okay, I just found another bug in the same functionality: |
|
@sebastian-sauer do you have any idea perhaps what might be causing |
|
I'll try to have a look into that. |
|
Looks like the reference to BeforeCommitID is wrong in the tmpl https://github.com/go-gitea/gitea/blob/main/templates/repo/diff/box.tmpl#L56 When only one commit is shown this should use AfterCommitID PR: #27916 |
wxiaoguang
approved these changes
Nov 5, 2023
GiteaBot
added
lgtm/done
lunny
added
the
reviewed/wait-merge
GiteaBot
pushed a commit
to GiteaBot/gitea
that referenced
this pull request
Nov 6, 2023
This should be the easiest fix. While other solutions might be possible that exterminate the root cause, they will not be as trivial.
GiteaBot
removed
the
reviewed/wait-merge
lunny
pushed a commit
that referenced
this pull request
Nov 6, 2023
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Nov 6, 2023
* upstream/main: Fix edit topic UI (go-gitea#27925) Unify two factor check (go-gitea#27915) Revert go-gitea#27870 (go-gitea#27917) Fix JS NPE when viewing specific range of PR commits (go-gitea#27912) Install poetry dependencies with --no-root (go-gitea#27919) Show correct commit sha when viewing single commit diff (go-gitea#27916) Fix 500 when deleting a dismissed review (go-gitea#27903) Remove action runners on user deletion (go-gitea#27902) Remove SSH workaround (go-gitea#27893) Remove "tabindex" from some form buttons (go-gitea#27892) Refactor the function RemoveOrgUser (go-gitea#27582) Fix DownloadFunc when migrating releases (go-gitea#27887)
fuxiaohei
pushed a commit
to fuxiaohei/gitea
that referenced
this pull request
Jan 17, 2024
This should be the easiest fix. While other solutions might be possible that exterminate the root cause, they will not be as trivial.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should be the easiest fix.
While other solutions might be possible that exterminate the root cause, they will not be as trivial.