Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrate alpine noarch packages into other architectures index #29137

Merged
merged 14 commits into from
Feb 25, 2024
Merged

Integrate alpine noarch packages into other architectures index #29137

merged 14 commits into from
Feb 25, 2024

Conversation

KN4CK3R
Copy link
Member

@KN4CK3R KN4CK3R commented Feb 11, 2024 •
edited
Loading

Fixes #26691
Revert #24972

The alpine package manager expects noarch packages in the index of other architectures too.

@KN4CK3R KN4CK3R added type/enhancement An improvement of existing functionality topic/packages labels Feb 11, 2024
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Feb 11, 2024
@pull-request-size pull-request-size bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Feb 11, 2024
@github-actions github-actions bot added the modifies/api This PR adds API routes or modifies them label Feb 11, 2024
@Xinayder
Copy link

This is a nice way to fix the issue with noarch packages in the Alpine registry. I used a different approach in Forgejo, based on the information gathered on the official Alpine channels that noarch packages are literally just copied to the available architectures in the repository.

However, one issue I had was when I uploaded a noarch package to a repository that doesn't exist. I believe the same issue is present in your PR, if the repo is new and the first package you're uploading is a noarch package, there are no available architectures on the repository and the noarch package won't be copied to the other architectures.

The other thing I can say is, while it's nice that you keep track of the noarch packages on a separate "repo", it's not something done by Alpine, since there is no noarch repository on the official registry and apk doesn't support it yet.

@KN4CK3R
Copy link
Member Author

KN4CK3R commented Feb 14, 2024

there are no available architectures on the repository and the noarch package won't be copied to the other architectures

Yes, I know about the problem if there is no other package which provides an architecture. I decided to ignore it because I don't want to set some default architecture which may be correct or incorrect, the system just can't know about it.

and apk doesn't support it yet.

Yes, maybe one client does in the future.

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Feb 15, 2024
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 24, 2024
lunny
lunny requested changes Feb 24, 2024
View reviewed changes
Copy link
Member

@lunny lunny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The typo @KN4CK3R mentioned should be fixed before merging.

@GiteaBot GiteaBot added lgtm/blocked A maintainer has reservations with the PR and thus it cannot be merged and removed lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. labels Feb 24, 2024
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/blocked A maintainer has reservations with the PR and thus it cannot be merged labels Feb 25, 2024
@silverwind silverwind added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Feb 25, 2024
@silverwind silverwind enabled auto-merge (squash) February 25, 2024 10:38
@lunny lunny disabled auto-merge February 25, 2024 12:59
@lunny lunny enabled auto-merge (squash) February 25, 2024 14:37
@lunny lunny merged commit 1c68585 into go-gitea:main Feb 25, 2024
26 checks passed
@GiteaBot GiteaBot added this to the 1.22.0 milestone Feb 25, 2024
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Feb 25, 2024
zjjhot added a commit to zjjhot/gitea that referenced this pull request Feb 26, 2024
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
2575481 
* giteaofficial/main: (45 commits)
  Include resource state events in Gitlab downloads (go-gitea#29382)
  Add API to get PR by base/head (go-gitea#29242)
  [skip ci] Updated translations via Crowdin
  Improve Documentation for Restoration from backup (go-gitea#29321)
  Refactor "user/active" related logic (go-gitea#29390)
  Remove jQuery AJAX from the archive download links (go-gitea#29380)
  Add tailwindcss (go-gitea#29357)
  Add missing space (go-gitea#29393)
  Integrate alpine `noarch` packages into other architectures index (go-gitea#29137)
  enforce maxlength in frontend (go-gitea#29389)
  Remove incorrect and unnecessary Escape from templates (go-gitea#29394)
  Make actions animation rotate counterclockwisely (go-gitea#29378)
  Use `crypto/sha256` (go-gitea#29386)
  Add `io.Closer` guidelines (go-gitea#29387)
  Remove jQuery AJAX from the notice selection deletion button (go-gitea#29381)
  Refactor Safe modifier (go-gitea#29392)
  Add attachment support for code review comments (go-gitea#29220)
  Refactor modules/git global variables (go-gitea#29376)
  Remove jQuery from the code diff expansion buttons (go-gitea#29385)
  Remove jQuery AJAX from the markdown editor preview (go-gitea#29384)
  ...
@KN4CK3R KN4CK3R deleted the fix-alpine-noarch branch February 26, 2024 08:18
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lafriks lafriks lafriks left review comments

@wxiaoguang wxiaoguang wxiaoguang approved these changes

@silverwind silverwind silverwind approved these changes

@lunny lunny lunny approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/api This PR adds API routes or modifies them size/L Denotes a PR that changes 100-499 lines, ignoring generated files. topic/packages type/enhancement An improvement of existing functionality
Projects
None yet
Milestone
1.22.0
Development

Successfully merging this pull request may close these issues.

Alpine Package Registry: Handling of 'noarch' packages
7 participants
@KN4CK3R @Xinayder @lunny @silverwind @lafriks @wxiaoguang @GiteaBot