Remove jQuery AJAX from the archive download links

[yardenshoham]

• Removed all jQuery AJAX calls and replaced with our fetch wrapper
• Tested the repo archive download links dropdown functionality and it works as before

Demo using fetch instead of jQuery AJAX

[yardenshoham]

BTW I'm not sure that logic adding the loading class to <i> is actually doing anything

[silverwind]

put the loading removal in a finally clause . This is important because fetch will throw on network errors.

[yardenshoham]

It shouldn't happen always so I put it in a catch but anyway these loading indicators are not working

[silverwind]

Now you have 3 code branches that remove the indicator, while a single finally would be sufficient as long as you don't return inside the try. Actually I think a finally may even execute when you return.

[zokkis]

Now you have 3 code branches that remove the indicator, while a single finally would be sufficient as long as you don't return inside the try. Actually I think a finally may even execute when you return.

Yes, finally executes always, even after return

[silverwind]

In fact it does:

(() => {
  try {
    return console.log('a');
  } finally {
    console.log('b');
  }
})();

Logs both "a" and "b".

[yardenshoham]

In the case complete is false we don't want to remove the loading indicator

[silverwind]

How about setting a let isComplete = true variable before the fetch, set it to false conditionally and check it during indicator removal and before the recursion?

[yardenshoham]

The code as it is right now has the same behavior as before. Logic changes should not go in this PR

[silverwind]

The code reads like ass but previous one did too, so whatever.

[yardenshoham]

Agreed on that front