-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Patch in exact search for meilisearch #29671
Conversation
because then we can use same name for issue search where default should be false
…o we have to post-filter the hits
@delvh the issue we talked at the TOC meeting about ... the problem is within meilisearch, so I only did come up with an workaround until meilisearch do address that on there side :/ |
Co-authored-by: delvh <dev.lh@web.de>
@silverwind I optimized and simplified the idea ... now it should be flat and normal maintainers should understand |
Created a followup issue forexpose fuzzines via WebUI -> #29685 |
* upstream/main: Patch in exact search for meilisearch (go-gitea#29671) Use more specific selector for `name` links (go-gitea#29679) Replace more gt- with tw- (go-gitea#29678) # Conflicts: # templates/user/dashboard/issues.tmpl
Hey! I just realized that Gitea is using Meilisearch. However, I am not sure about the missing feature here. Can you explain your use case in great detail, please? It seems that reducing the typo tolerance is possible. It's also possible to disallow typos on specific fields. But it doesn't seem to fit your needs. |
@Kerollmops hi 👋 we have two modes "fuzzy" search and non-fuzzy "match". the code indexer has it exposed to the UI already, as for searching issues/pulls we do not jet and use non-fuzzy search by default. Meilisearch is currently only possible to be used for the issue/pull search but code-serch will be added ... (#25976). So the problem here is, that in non-fuzzy mode, that meilisearch returns hits that have no direct hit. let's say i'm searching If i understand the meilisearch-docs correctly you can adjust that behavior per index. So now we either have to have an index clone one with fuzzynes and one without, or we post-sort it. In the long run there should be just an query option like we use e.g. with elasticsearch: gitea/modules/indexer/issues/elasticsearch/elasticsearch.go Lines 149 to 154 in 7f856d5
|
or as with bleve ... (#29706) |
Hey @6543, Thank you for the clear explanation. So, exposing the Another quick fix for your issue could be to double-quote every query word. Doing this disallows typos on those words and forces the documents to have all the double-quoted words. However, it's not that easy to put in place on your side. |
@Kerollmops would that work -> #29740 ? PS: we should chat onwards in #29740 ... as it's discouraged to chat in merged/closed issues/pulls :) |
meilisearch does not have an search option to contorl fuzzynes per query right now:
so we have to create a workaround by post-filter the search result in gitea until this is addressed.
For future works I added an option in backend only atm, to enable fuzzynes for issue indexer too.
And also refactored the code so the fuzzy option is equal in logic to code indexer
Sponsored by Kithara Software GmbH