Replace more gt- with tw- #29678
Merged
Replace more gt- with tw- #29678
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/M
silverwind
added
the
skip-changelog
yardenshoham
approved these changes
Mar 8, 2024
GiteaBot
added
lgtm/need 1
denyskon
approved these changes
Mar 8, 2024
GiteaBot
added
lgtm/done
denyskon
added
topic/ui
GiteaBot
removed
the
reviewed/wait-merge
wxiaoguang
reviewed
Mar 9, 2024
| @@ -59,7 +59,7 @@ func (p *AuthSourceProvider) DisplayName() string { | |||
|
|
|||
| func (p *AuthSourceProvider) IconHTML(size int) template.HTML { | |||
| if p.iconURL != "" { | |||
| img := fmt.Sprintf(`<img class="gt-object-contain gt-mr-3" width="%d" height="%d" src="%s" alt="%s">`, | |||
| img := fmt.Sprintf(`<img class="tw-object-contain gt-mr-3" width="%d" height="%d" src="%s" alt="%s">`, | |||
There was a problem hiding this comment.
Does tailwind config scan "*.go" files?
This is the only use of "tw-object-contain"
There was a problem hiding this comment.
Ah, we need to fix that.
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Mar 9, 2024
* upstream/main: Patch in exact search for meilisearch (go-gitea#29671) Use more specific selector for `name` links (go-gitea#29679) Replace more gt- with tw- (go-gitea#29678) # Conflicts: # templates/user/dashboard/issues.tmpl
silverwind
added a commit
that referenced
this pull request
Mar 9, 2024
We need to scan `.go` files for tailwind classes. Does not seem to affect build time much luckily. Fixes: #29678 (comment) Verified via `rg tw-object-contain public/assets/css/index.css`. --------- Co-authored-by: Giteabot <teabot@gitea.io>
DennisRasey
pushed a commit
to DennisRasey/forgejo
that referenced
this pull request
Mar 13, 2024
We need to scan `.go` files for tailwind classes. Does not seem to affect build time much luckily. Fixes: go-gitea/gitea#29678 (comment) Verified via `rg tw-object-contain public/assets/css/index.css`. --------- Co-authored-by: Giteabot <teabot@gitea.io> (cherry picked from commit 1695a5ac74afc51f38fd3a1def76cff6ba8d8641)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will conclude the trivial class replacements.