Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add result check in TestAPIEditUser #29674

Merged
merged 10 commits into from
May 5, 2024
Merged

Add result check in TestAPIEditUser #29674

merged 10 commits into from
May 5, 2024

Conversation

yp05327
Copy link
Contributor

@yp05327 yp05327 commented Mar 8, 2024 •
edited
Loading

Fix #29514
there are too many usage of NewRequestWithValues, so there's no need to check all of them.
Just one is enough I think.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Mar 8, 2024
@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 8, 2024
@yp05327 yp05327 marked this pull request as draft March 8, 2024 15:25
@silverwind silverwind added type/testing skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. labels Mar 8, 2024
@pull-request-size pull-request-size bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 21, 2024
@github-actions github-actions bot added the modifies/go Pull requests that update Go code label Mar 21, 2024
@yp05327
Copy link
Contributor Author

yp05327 commented Mar 21, 2024

wait for https://gitea.com/go-chi/binding/pulls/16

@pull-request-size pull-request-size bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 22, 2024
@yp05327 yp05327 marked this pull request as ready for review March 22, 2024 00:15
@techknowlogick
Copy link
Member

wait for https://gitea.com/go-chi/binding/pulls/16

now that the binding PR has been merged, can this be reviewed?

@yp05327
Copy link
Contributor Author

yp05327 commented Apr 8, 2024 •
edited
Loading

CI failures seem related, I will check it.

@yp05327
Copy link
Contributor Author

yp05327 commented Apr 8, 2024

https://gitea.com/go-chi/binding/pulls/17
still have some issues, wait for this one.

@yp05327 yp05327 mentioned this pull request Apr 30, 2024
Merged
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Apr 30, 2024
@yp05327 yp05327 mentioned this pull request May 2, 2024
Merged
@lunny lunny added the backport/v1.22 This PR should be backported to Gitea 1.22 label May 2, 2024
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 4, 2024
@pull-request-size pull-request-size bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 5, 2024
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label May 5, 2024
@lunny lunny enabled auto-merge (squash) May 5, 2024 01:44
@lunny lunny merged commit ecd1d96 into go-gitea:main May 5, 2024
26 checks passed
@GiteaBot GiteaBot added this to the 1.23.0 milestone May 5, 2024
GiteaBot pushed a commit to GiteaBot/gitea that referenced this pull request May 5, 2024
@yp05327 @GiteaBot
Add result check in TestAPIEditUser (go-gitea#29674)
0b2f3c9 
Fix go-gitea#29514
There are too many usage of `NewRequestWithValues`, so there's no need
to check all of them.
Just one is enough I think.
@GiteaBot GiteaBot mentioned this pull request May 5, 2024
Merged
@GiteaBot GiteaBot added backport/done All backports for this PR have been created and removed reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. labels May 5, 2024
lunny pushed a commit that referenced this pull request May 5, 2024
@GiteaBot @yp05327
Add result check in TestAPIEditUser (#29674) (#30860)
0546029 
Backport #29674 by @yp05327

Fix #29514
there are too many usage of `NewRequestWithValues`, so there's no need
to check all of them.
Just one is enough I think.

Co-authored-by: yp05327 <576951401@qq.com>
zjjhot added a commit to zjjhot/gitea that referenced this pull request May 6, 2024
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
7e56799 
* giteaofficial/main:
  Have time.js use UTC-related getters/setters (go-gitea#30857)
  Do not show monaco JS errors (go-gitea#30862)
  Fix issue/PR title edit (go-gitea#30858)
  Add result check in TestAPIEditUser (go-gitea#29674)
@yp05327 yp05327 deleted the add-result-check-in-TestAPIEditUser branch July 30, 2024 00:50
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Aug 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@yardenshoham yardenshoham yardenshoham approved these changes

@lunny lunny lunny approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created backport/v1.22 This PR should be backported to Gitea 1.22 lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/go Pull requests that update Go code size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/testing
Projects
None yet
Milestone
1.23.0
Development

Successfully merging this pull request may close these issues.

The usage of NewRequestWithValues(t, "PATCH", url, data) doesn't work in tests
6 participants
@yp05327 @techknowlogick @lunny @yardenshoham @silverwind @GiteaBot