Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue/PR title edit #30858

Merged
merged 3 commits into from
May 5, 2024
Merged

Fix issue/PR title edit #30858

merged 3 commits into from
May 5, 2024

Conversation

wxiaoguang
Copy link
Contributor

@wxiaoguang wxiaoguang commented May 4, 2024 •
edited
Loading

No description provided.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label May 4, 2024
@pull-request-size pull-request-size bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label May 4, 2024
@wxiaoguang wxiaoguang added type/bug backport/v1.22 This PR should be backported to Gitea 1.22 labels May 4, 2024
@github-actions github-actions bot added modifies/templates This PR modifies the template files modifies/js labels May 4, 2024
@wxiaoguang wxiaoguang force-pushed the fix-issue-edit branch 2 times, most recently from 9fd3b2e to c629eed Compare May 4, 2024 14:47
@wxiaoguang wxiaoguang mentioned this pull request May 4, 2024
Closed
@github-actions github-actions bot added the modifies/go Pull requests that update Go code label May 4, 2024
@lunny
Copy link
Member

lunny commented May 5, 2024

The height of the edit input is not align with the right buttons.

@wxiaoguang
Copy link
Contributor Author

wxiaoguang commented May 5, 2024 •
edited
Loading

1c10119

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels May 5, 2024
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 5, 2024
@wxiaoguang wxiaoguang enabled auto-merge (squash) May 5, 2024 12:48
@wxiaoguang wxiaoguang merged commit 5c236bd into go-gitea:main May 5, 2024
26 checks passed
@GiteaBot GiteaBot added this to the 1.23.0 milestone May 5, 2024
GiteaBot pushed a commit to GiteaBot/gitea that referenced this pull request May 5, 2024
@wxiaoguang @GiteaBot
Fix issue/PR title edit (go-gitea#30858)
70d371c 
1. "enter" doesn't work (I think it is the last enter support for go-gitea#14843)
2. if a branch name contains something like `&`, then the branch selector doesn't update
@GiteaBot GiteaBot mentioned this pull request May 5, 2024
Merged
@GiteaBot GiteaBot added the backport/done All backports for this PR have been created label May 5, 2024
@wxiaoguang wxiaoguang deleted the fix-issue-edit branch May 5, 2024 13:26
wxiaoguang added a commit that referenced this pull request May 5, 2024
@GiteaBot @wxiaoguang
Fix issue/PR title edit (#30858) (#30865)
60fa2a5 
Backport #30858 by wxiaoguang

1. "enter" doesn't work (I think it is the last enter support for #14843)
2. if a branch name contains something like `&`, then the branch selector doesn't update

Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
zjjhot added a commit to zjjhot/gitea that referenced this pull request May 6, 2024
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
7e56799 
* giteaofficial/main:
  Have time.js use UTC-related getters/setters (go-gitea#30857)
  Do not show monaco JS errors (go-gitea#30862)
  Fix issue/PR title edit (go-gitea#30858)
  Add result check in TestAPIEditUser (go-gitea#29674)
@wxiaoguang wxiaoguang mentioned this pull request May 16, 2024
Merged
@GiteaBot GiteaBot mentioned this pull request May 16, 2024
Merged
silverwind pushed a commit that referenced this pull request May 17, 2024
@GiteaBot @wxiaoguang
Fix JS error when editing a merged PR's title (#30990) (#31001)
bd3787c 
Backport #30990 by @wxiaoguang

Regression of Fix issue/PR title edit (#30858)

Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
DennisRasey pushed a commit to DennisRasey/forgejo that referenced this pull request May 21, 2024
@wxiaoguang
Port: Fix issue/PR title edit (gitea#30858) (#3797)
d4b1ed8 
This PR ports [gitea#30858](go-gitea/gitea#30858) / [this commit](go-gitea/gitea@5c236bd) to forgejo.

[week 2024-20 cherry pick](https://codeberg.org/forgejo/forgejo/pulls/3729)

## Tests
- [ ] Click "edit" to get into edit mode, change the title and then use Alt+Enter to save the title

## Screenshots

Before:
![grafik](/attachments/bb0b2562-7da0-4205-a647-3270d66f2ad7)
![grafik](/attachments/c3d05a21-659d-4616-b357-87de57232182)

After:
![grafik](/attachments/d9af6966-3282-439b-a845-76618a24b9a6)
![grafik](/attachments/5acd6684-69c4-41a4-8e27-7cb75fe3c7e4)

Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/3797
Reviewed-by: 0ko <0ko@noreply.codeberg.org>
Co-authored-by: Mai-Lapyst <mai-lapyst@noreply.codeberg.org>
Co-committed-by: Mai-Lapyst <mai-lapyst@noreply.codeberg.org>
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Aug 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@KN4CK3R KN4CK3R KN4CK3R approved these changes

@lunny lunny lunny approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created backport/v1.22 This PR should be backported to Gitea 1.22 lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/go Pull requests that update Go code modifies/js modifies/templates This PR modifies the template files size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/bug
Projects
None yet
Milestone
1.23.0
Development

Successfully merging this pull request may close these issues.
4 participants
@wxiaoguang @lunny @KN4CK3R @GiteaBot