Fix path escaping in 'Find files' #30025
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/XS
github-actions
bot
added
the
modifies/templates
wxiaoguang
reviewed
Mar 23, 2024
There was a problem hiding this comment.
Sorry , it is not right ... I will propose a new fix.
-> Escape paths for find file correctly #30026
|
It is right and exactly the same outcome as yours. |
|
But yes, I agree it's better done in go code instead of templates. |
Outcome is the same doesn't mean the underlying logic is right. For this case: the "DataLink" is a "Link" from backend, so it should be a fully escaped and 100% correct URL link. It shouldn't be "escaped" again. Otherwise, it would cause double-escaping in the future. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #30020
Before:
After:
