Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Escape paths for find file correctly #30026

Merged
merged 3 commits into from
Mar 23, 2024
Merged

Escape paths for find file correctly #30026

merged 3 commits into from
Mar 23, 2024

Conversation

wxiaoguang
Copy link
Contributor

@wxiaoguang wxiaoguang commented Mar 23, 2024 •
edited
Loading

Fix #30020

image

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Mar 23, 2024
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 23, 2024
@github-actions github-actions bot added the modifies/go Pull requests that update Go code label Mar 23, 2024
@wxiaoguang wxiaoguang added this to the 1.22.0 milestone Mar 23, 2024
@wxiaoguang wxiaoguang added type/bug backport/v1.21 This PR should be backported to Gitea 1.21 labels Mar 23, 2024
@wxiaoguang wxiaoguang mentioned this pull request Mar 23, 2024
Closed
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Mar 23, 2024
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 23, 2024
@wxiaoguang wxiaoguang enabled auto-merge (squash) March 23, 2024 12:21
@yardenshoham yardenshoham added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Mar 23, 2024
@wxiaoguang wxiaoguang merged commit 1cdc6c3 into go-gitea:main Mar 23, 2024
26 checks passed
@GiteaBot
Copy link
Collaborator

I was unable to create a backport for 1.21. @wxiaoguang, please send one manually. 🍵

go run ./contrib/backport 30026
...  // fix git conflicts if any
go run ./contrib/backport --continue

@GiteaBot GiteaBot added backport/manual No power to the bots! Create your backport yourself! and removed reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. labels Mar 23, 2024
@wxiaoguang wxiaoguang deleted the fix-find-file-path branch March 23, 2024 15:04
wxiaoguang added a commit to wxiaoguang/gitea that referenced this pull request Mar 23, 2024
@wxiaoguang
Escape paths for find file correctly (go-gitea#30026)
ac68e90
@wxiaoguang wxiaoguang mentioned this pull request Mar 23, 2024
Merged
@lunny lunny added the backport/done All backports for this PR have been created label Mar 23, 2024
silverwind pushed a commit that referenced this pull request Mar 23, 2024
@wxiaoguang
Escape paths for find file correctly (#30026) (#30031)
2172b38 
Backport #30026
silverwind pushed a commit to silverwind/gitea that referenced this pull request Mar 23, 2024
@wxiaoguang @silverwind
Escape paths for find file correctly (go-gitea#30026)
f36433f 
Fix go-gitea#30020
silverwind added a commit to silverwind/gitea that referenced this pull request Mar 23, 2024
@silverwind
Merge remote-tracking branch 'origin/main' into fontsize
4412eee 
* origin/main:
  Replace all simple inline styles with tailwind (go-gitea#30032)
  Migrate font-weight helpers to tailwind (go-gitea#30027)
  Remove jQuery from the issue "go to" button (go-gitea#30028)
  Determine fuzziness of bleve indexer by keyword length (go-gitea#29706)
  Escape paths for find file correctly (go-gitea#30026)
zjjhot added a commit to zjjhot/gitea that referenced this pull request Mar 24, 2024
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
207fc43 
* giteaofficial/main: (28 commits)
  Enable a few stylelint rules (go-gitea#30038)
  Remove remaining jQuery .css code (go-gitea#30015)
  Respect DEFAULT_ORG_MEMBER_VISIBLE setting when adding creator to org (go-gitea#30013)
  Remove jQuery `.attr` from the common global functions (go-gitea#30023)
  Migrate font-size helpers to tailwind (go-gitea#30029)
  Replace all simple inline styles with tailwind (go-gitea#30032)
  Migrate font-weight helpers to tailwind (go-gitea#30027)
  Remove jQuery from the issue "go to" button (go-gitea#30028)
  Determine fuzziness of bleve indexer by keyword length (go-gitea#29706)
  Escape paths for find file correctly (go-gitea#30026)
  Remove jQuery `.attr` from the diff page (go-gitea#30021)
  Remove jQuery `.attr` from the repository settings (go-gitea#30018)
  Remove jQuery `.attr` from the image diff again (go-gitea#30022)
  Introduce `.secondary-nav` and handle `.page-content` spacing universally (go-gitea#29982)
  Remove jQuery `.attr` from the branch/tag selector (go-gitea#30010)
  Remove jQuery `.attr` from the commit graph (go-gitea#30006)
  Remove jQuery from the citation modal (except fomantic) (go-gitea#30008)
  Remove jQuery `.attr` from the project page (go-gitea#30004)
  Fix incorrect tailwind migration (go-gitea#30007)
  Enforce trailing comma in JS on multiline (go-gitea#30002)
  ...
TKaxv-7S added a commit to TKaxv-7S/gitea that referenced this pull request Apr 10, 2024
@TKaxv-7S
Merge tag 'refs/tags/v1.21.10' into release/v1.21-tk
37da8c7 
v1.21.10
* BUGFIXES
  * Fix Add/Remove WIP on pull request title failure (go-gitea#29999) (go-gitea#30066)
  * Fix misuse of `TxContext` (go-gitea#30061) (go-gitea#30062)
  * Respect DEFAULT_ORG_MEMBER_VISIBLE setting when adding creator to org (go-gitea#30013) (go-gitea#30035)
  * Escape paths for find file correctly (go-gitea#30026) (go-gitea#30031)
  * Remove duplicate option in admin screen and now-unused translation keys (go-gitea#28492) (go-gitea#30024)
  * Fix manual merge form and 404 page templates (go-gitea#30000)

# gpg: Signature made Tue, Mar 26, 2024  7:48:36 AM
# gpg:                using EDDSA key 8722B61D72341082553B201CB8BE6D610E61C862
# gpg: Can't check signature: No public key
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Jun 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@delvh delvh delvh approved these changes

@silverwind silverwind silverwind approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created backport/manual No power to the bots! Create your backport yourself! backport/v1.21 This PR should be backported to Gitea 1.21 lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/go Pull requests that update Go code size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. type/bug
Projects
None yet
Milestone
1.22.0
Development

Successfully merging this pull request may close these issues.

"Go to file" doesn't work for branches containing a #
6 participants
@wxiaoguang @GiteaBot @silverwind @delvh @lunny @yardenshoham