Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix border-radius of header+segment boxes #30667

Merged
merged 2 commits into from
Apr 24, 2024

Conversation

silverwind
Copy link
Member

@silverwind silverwind commented Apr 23, 2024

This is a very old bug with the bottom border-radiuses not being there and the :has selector now makes it possible to cleanly solve it. It affects all header+segment boxes, which there are many throughout the UI:

Screenshot 2024-04-23 at 20 47 21

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Apr 23, 2024
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 23, 2024
@silverwind silverwind added the backport/v1.22 This PR should be backported to Gitea 1.22 label Apr 23, 2024
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Apr 23, 2024
@lunny
Copy link
Member

lunny commented Apr 24, 2024

I created #30673 to list almost all the possible UI border-radius problems after this PR.

@silverwind
Copy link
Member Author

I imagine this PR likely fixes half of them.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 24, 2024
@lunny
Copy link
Member

lunny commented Apr 24, 2024

I imagine this PR likely fixes half of them.

That PR just listed all problems which haven't been fixed by this PR.

@silverwind
Copy link
Member Author

Ok, wouldn't have thought there'd be still so many. I will check them out later.

@silverwind silverwind added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Apr 24, 2024
@silverwind silverwind enabled auto-merge (squash) April 24, 2024 08:51
@silverwind silverwind removed the backport/v1.22 This PR should be backported to Gitea 1.22 label Apr 24, 2024
@silverwind silverwind merged commit 3f19a63 into go-gitea:main Apr 24, 2024
26 checks passed
@GiteaBot GiteaBot added this to the 1.23.0 milestone Apr 24, 2024
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Apr 24, 2024
@silverwind silverwind deleted the radius-segments branch April 24, 2024 13:25
silverwind added a commit to pangliang/gitea that referenced this pull request Apr 24, 2024
…low_dispatch_event

* origin/main: (62 commits)
  Add test for go-gitea#30674 (go-gitea#30679)
  Fix border-radius of header+segment boxes (go-gitea#30667)
  Fix a panic bug when head repository deleting (go-gitea#30674)
  Fix some bug on migrations (go-gitea#30647)
  Fix checkbox field markup (go-gitea#30666)
  Avoid doubled border for the PR info segment (go-gitea#30663)
  Interpolate runs-on with variables when scheduling tasks (go-gitea#30640)
  Initial support for colorblindness-friendly themes (go-gitea#30625)
  Fix flash message for flex-container (go-gitea#30657)
  Perform Newest sort type correctly when sorting issues (go-gitea#30644)
  Fix project name wrapping, remove horizontal margin on header (go-gitea#30631)
  Add a db consistency check to remove runners that do not belong to a repository (go-gitea#30614)
  Fix wrong table name (go-gitea#30557)
  Fix compare api swagger (go-gitea#30648)
  [skip ci] Updated translations via Crowdin
  Fix queue test (go-gitea#30646)
  Enable jquery-related eslint rules that have no violations (go-gitea#30632)
  Enable more `revive` linter rules (go-gitea#30608)
  Remove obsolete CSS text classes (go-gitea#30576)
  Hide diff stats on empty PRs (go-gitea#30629)
  ...
zjjhot added a commit to zjjhot/gitea that referenced this pull request Apr 25, 2024
* giteaofficial/main:
  If a repository return no commitstatus, then still cache it but not query it from database (go-gitea#30700)
  [skip ci] Updated translations via Crowdin
  Fix view of readme file in the home code page. (go-gitea#30564)
  Add test for go-gitea#30674 (go-gitea#30679)
  Fix border-radius of header+segment boxes (go-gitea#30667)
@wxiaoguang wxiaoguang modified the milestones: 1.23.0, 1.22.0 Apr 27, 2024
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Jul 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants