Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a panic bug when head repository deleting #30674

Merged
merged 1 commit into from
Apr 24, 2024
Merged

Fix a panic bug when head repository deleting #30674

merged 1 commit into from
Apr 24, 2024

Conversation

lunny
Copy link
Member

@lunny lunny commented Apr 24, 2024 •
edited
Loading

When visiting a pull request files which head repository has been deleted, it will panic because headrepo is nil.

@lunny lunny added the type/bug label Apr 24, 2024
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Apr 24, 2024
@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Apr 24, 2024
@github-actions github-actions bot added the modifies/go Pull requests that update Go code label Apr 24, 2024
@lunny lunny added the backport/v1.22 This PR should be backported to Gitea 1.22 label Apr 24, 2024
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Apr 24, 2024
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 24, 2024
@lunny lunny merged commit 8b36324 into go-gitea:main Apr 24, 2024
26 checks passed
@GiteaBot GiteaBot added this to the 1.23.0 milestone Apr 24, 2024
@lunny lunny deleted the lunny/fix_bug_pr_files branch April 24, 2024 05:26
GiteaBot pushed a commit to GiteaBot/gitea that referenced this pull request Apr 24, 2024
@lunny @GiteaBot
Fix a panic bug when head repository deleting (go-gitea#30674)
c2ff032 
When visiting a pull request files which head repository has been
deleted, it will panic because headrepo is nil.
@GiteaBot GiteaBot mentioned this pull request Apr 24, 2024
Merged
@GiteaBot GiteaBot added the backport/done All backports for this PR have been created label Apr 24, 2024
zjjhot added a commit to zjjhot/gitea that referenced this pull request Apr 24, 2024
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
4b88f93 
* giteaofficial/main:
  Fix a panic bug when head repository deleting (go-gitea#30674)
  Fix some bug on migrations (go-gitea#30647)
  Fix checkbox field markup (go-gitea#30666)
  Avoid doubled border for the PR info segment (go-gitea#30663)
  Interpolate runs-on with variables when scheduling tasks (go-gitea#30640)
  Initial support for colorblindness-friendly themes (go-gitea#30625)
  Fix flash message for flex-container (go-gitea#30657)
  Perform Newest sort type correctly when sorting issues (go-gitea#30644)
  Fix project name wrapping, remove horizontal margin on header (go-gitea#30631)
  Add a db consistency check to remove runners that do not belong to a repository (go-gitea#30614)
  Fix wrong table name (go-gitea#30557)
  Fix compare api swagger (go-gitea#30648)
  [skip ci] Updated translations via Crowdin
  Fix queue test (go-gitea#30646)
  Enable jquery-related eslint rules that have no violations (go-gitea#30632)
  Enable more `revive` linter rules (go-gitea#30608)
  Remove obsolete CSS text classes (go-gitea#30576)
  Hide diff stats on empty PRs (go-gitea#30629)
lunny added a commit that referenced this pull request Apr 24, 2024
@lunny
Add test for #30674 (#30679)
a19d2bb
lunny added a commit that referenced this pull request Apr 25, 2024
@GiteaBot @lunny
Fix a panic bug when head repository deleting (#30674) (#30676)
bb6edb2 
Backport #30674 & #30679 by @lunny

When visiting a pull request files which head repository has been
deleted, it will panic because headrepo is nil.

---------

Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
zjjhot added a commit to zjjhot/gitea that referenced this pull request Apr 25, 2024
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
e9392c1 
* giteaofficial/main:
  If a repository return no commitstatus, then still cache it but not query it from database (go-gitea#30700)
  [skip ci] Updated translations via Crowdin
  Fix view of readme file in the home code page. (go-gitea#30564)
  Add test for go-gitea#30674 (go-gitea#30679)
  Fix border-radius of header+segment boxes (go-gitea#30667)
@wxiaoguang wxiaoguang added the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label Apr 27, 2024
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Jul 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@yp05327 yp05327 yp05327 approved these changes

@Zettat123 Zettat123 Zettat123 approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created backport/v1.22 This PR should be backported to Gitea 1.22 lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/go Pull requests that update Go code size/S Denotes a PR that changes 10-29 lines, ignoring generated files. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/bug
Projects
None yet
Milestone
1.23.0
Development

Successfully merging this pull request may close these issues.
5 participants
@lunny @Zettat123 @yp05327 @wxiaoguang @GiteaBot