Fix JS error when edit the title of merged PR #30988
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
yp05327
commented
May 16, 2024
yp05327
commented
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/XS
wxiaoguang
reviewed
May 16, 2024
| const oldTargetBranch = document.querySelector('#branch_target').textContent; | ||
| // merged pr can not edit target branch, so they maybe null | ||
| const newTargetBranch = document.querySelector('#pull-target-branch')?.getAttribute('data-branch'); | ||
| const oldTargetBranch = document.querySelector('#branch_target')?.textContent; |
There was a problem hiding this comment.
Thank you for catching the bug, I missed a case.
But I think we shouldn't use ? everywhere, and it doesn't seem right here, it would make newTargetBranch !== oldTargetBranch become true.
-> Fix JS error when editing a merged PR's title #30990
There was a problem hiding this comment.
Actually it is reported from @lunny
I will close this one.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.