Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix JS error when editing a merged PR's title #30990

Merged
merged 2 commits into from
May 16, 2024

Conversation

wxiaoguang
Copy link
Contributor

Regression of Fix issue/PR title edit (#30858)

@wxiaoguang wxiaoguang added type/bug skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. backport/v1.22 This PR should be backported to Gitea 1.22 labels May 16, 2024
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label May 16, 2024
@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label May 16, 2024
@github-actions github-actions bot added modifies/templates This PR modifies the template files modifies/js labels May 16, 2024
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels May 16, 2024
@wxiaoguang wxiaoguang requested a review from lunny May 16, 2024 02:03
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 16, 2024
@wxiaoguang wxiaoguang enabled auto-merge (squash) May 16, 2024 12:37
@wxiaoguang wxiaoguang merged commit 740b6e1 into go-gitea:main May 16, 2024
26 checks passed
@GiteaBot GiteaBot added this to the 1.23.0 milestone May 16, 2024
@wxiaoguang wxiaoguang deleted the fix-pr-edit branch May 16, 2024 13:47
GiteaBot pushed a commit to GiteaBot/gitea that referenced this pull request May 16, 2024
@GiteaBot GiteaBot added the backport/done All backports for this PR have been created label May 16, 2024
silverwind pushed a commit that referenced this pull request May 17, 2024
Backport #30990 by @wxiaoguang

Regression of Fix issue/PR title edit (#30858)

Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
zjjhot added a commit to zjjhot/gitea that referenced this pull request May 17, 2024
* giteaofficial/main:
  [skip ci] Updated translations via Crowdin
  Upgrade `tqdm` dependency (go-gitea#30996)
  Fix JS error when editing a merged PR's title (go-gitea#30990)
  template: `label` fix correct input id (go-gitea#30987)
DennisRasey pushed a commit to DennisRasey/forgejo that referenced this pull request May 20, 2024
Closes https://codeberg.org/forgejo/forgejo/issues/3743.

This is a simple fix for https://codeberg.org/forgejo/forgejo/issues/3743, based on changes in [gitea#30990](go-gitea/gitea#30990), which was not included in https://codeberg.org/forgejo/forgejo/pulls/3838 due to large code differences.

Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/3840
Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org>
DennisRasey pushed a commit to DennisRasey/forgejo that referenced this pull request May 20, 2024
Closes https://codeberg.org/forgejo/forgejo/issues/3743.

This is a simple fix for https://codeberg.org/forgejo/forgejo/issues/3743, based on changes in [gitea#30990](go-gitea/gitea#30990), which was not included in https://codeberg.org/forgejo/forgejo/pulls/3838 due to large code differences.

Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/3840
Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org>
(cherry picked from commit 3351ce2)
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Aug 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport/done All backports for this PR have been created backport/v1.22 This PR should be backported to Gitea 1.22 lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/js modifies/templates This PR modifies the template files size/S Denotes a PR that changes 10-29 lines, ignoring generated files. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants