-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix JS error when editing a merged PR's title #30990
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wxiaoguang
added
type/bug
skip-changelog
This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features.
backport/v1.22
This PR should be backported to Gitea 1.22
labels
May 16, 2024
GiteaBot
added
the
lgtm/need 2
This PR needs two approvals by maintainers to be considered for merging.
label
May 16, 2024
pull-request-size
bot
added
the
size/S
Denotes a PR that changes 10-29 lines, ignoring generated files.
label
May 16, 2024
github-actions
bot
added
modifies/templates
This PR modifies the template files
modifies/js
labels
May 16, 2024
yp05327
approved these changes
May 16, 2024
GiteaBot
added
lgtm/need 1
This PR needs approval from one additional maintainer to be merged.
and removed
lgtm/need 2
This PR needs two approvals by maintainers to be considered for merging.
labels
May 16, 2024
silverwind
approved these changes
May 16, 2024
GiteaBot
added
lgtm/done
This PR has enough approvals to get merged. There are no important open reservations anymore.
and removed
lgtm/need 1
This PR needs approval from one additional maintainer to be merged.
labels
May 16, 2024
GiteaBot
pushed a commit
to GiteaBot/gitea
that referenced
this pull request
May 16, 2024
silverwind
pushed a commit
that referenced
this pull request
May 17, 2024
Backport #30990 by @wxiaoguang Regression of Fix issue/PR title edit (#30858) Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
May 17, 2024
* giteaofficial/main: [skip ci] Updated translations via Crowdin Upgrade `tqdm` dependency (go-gitea#30996) Fix JS error when editing a merged PR's title (go-gitea#30990) template: `label` fix correct input id (go-gitea#30987)
DennisRasey
pushed a commit
to DennisRasey/forgejo
that referenced
this pull request
May 20, 2024
Closes https://codeberg.org/forgejo/forgejo/issues/3743. This is a simple fix for https://codeberg.org/forgejo/forgejo/issues/3743, based on changes in [gitea#30990](go-gitea/gitea#30990), which was not included in https://codeberg.org/forgejo/forgejo/pulls/3838 due to large code differences. Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/3840 Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org>
DennisRasey
pushed a commit
to DennisRasey/forgejo
that referenced
this pull request
May 20, 2024
Closes https://codeberg.org/forgejo/forgejo/issues/3743. This is a simple fix for https://codeberg.org/forgejo/forgejo/issues/3743, based on changes in [gitea#30990](go-gitea/gitea#30990), which was not included in https://codeberg.org/forgejo/forgejo/pulls/3838 due to large code differences. Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/3840 Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org> (cherry picked from commit 3351ce2)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
backport/done
All backports for this PR have been created
backport/v1.22
This PR should be backported to Gitea 1.22
lgtm/done
This PR has enough approvals to get merged. There are no important open reservations anymore.
modifies/js
modifies/templates
This PR modifies the template files
size/S
Denotes a PR that changes 10-29 lines, ignoring generated files.
skip-changelog
This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features.
type/bug
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regression of Fix issue/PR title edit (#30858)