Repo Activity: count new issues that were closed #31776
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/M
tmnvanderberg
changed the title
Previously, closed issues would not be shown under new issues in the activity tab, even if they were newly created. changes: * Split out newlyCreatedIssues from issuesForActivityStatement to count both currently open and closed issues. * Use a seperate function to count active issues to prevent double-counting issues. Signed-off-by: Timon van der Berg <tmnvanderberg@gmail.com>
lunny
reviewed
Aug 5, 2024
lunny
reviewed
Aug 5, 2024
lunny
approved these changes
Aug 5, 2024
GiteaBot
added
lgtm/need 1
|
last call for merge @go-gitea/technical-oversight-committee |
delvh
reviewed
Sep 21, 2024
|
|
||
| func activeIssues(ctx context.Context, repoID int64, fromTime time.Time) *xorm.Session { | ||
| sess := db.GetEngine(ctx).Where("issue.repo_id = ?", repoID). | ||
| And("issue.is_pull = ?", false). |
There was a problem hiding this comment.
I am a bit confused, in the issue it explicitly states:
For PRs, it is basically the same issue.
but they are excluded right now?
So do they have the same problem or not?
Apart from that, LGTM.
There was a problem hiding this comment.
You're right, pull requests suffer from the same problem. So this fix is only for part of the problem affecting the issue counts.
However, that is unrelated to this code snippet which is counting issues, and hence should filter out pull requets.
If this PR is approved I will be happy to submit a similar fix for pull requests.
delvh
approved these changes
Sep 21, 2024
GiteaBot
added
lgtm/done
lunny
added
the
reviewed/wait-merge
GiteaBot
removed
the
reviewed/wait-merge
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Sep 23, 2024
* giteaofficial/main: [skip ci] Updated licenses and gitignores Fix rename branch permission bug (go-gitea#32066) Fix artifact v4 upload above 8MB (go-gitea#31664) [skip ci] Updated translations via Crowdin Add bin to Composer Metadata (go-gitea#32099) Fix wrong last modify time (go-gitea#32102) Fix upload maven pacakge parallelly (go-gitea#31851) Repo Activity: count new issues that were closed (go-gitea#31776) Count typescript files as frontend for labeling (go-gitea#32088) Use camo.Always instead of camo.Allways (go-gitea#32097)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm new to go and contributing to gitea, your guidance is much appreciated.
This is meant to solve #13309
Previously, closed issues would not be shown under new issues in the
activity tab, even if they were newly created.
changes:
both currently open and closed issues.
double-counting issues after the above change.
Result is that new issues that have been closed are shown both under "new" and "closed".