Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rename branch permission bug #32066

Merged
merged 2 commits into from
Sep 22, 2024
Merged

Conversation

lunny
Copy link
Member

@lunny lunny commented Sep 17, 2024

The previous implementation requires admin permission to rename branches which should be write permission.

Fix #31993

@lunny lunny added type/bug backport/v1.22 This PR should be backported to Gitea 1.22 labels Sep 17, 2024
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Sep 17, 2024
@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 17, 2024
@github-actions github-actions bot added modifies/go Pull requests that update Go code modifies/templates This PR modifies the template files labels Sep 17, 2024
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Sep 18, 2024
@yp05327 yp05327 added this to the 1.23.0 milestone Sep 18, 2024
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Sep 22, 2024
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Sep 22, 2024
@lunny lunny enabled auto-merge (squash) September 22, 2024 17:33
@lunny lunny merged commit 9e0db1b into go-gitea:main Sep 22, 2024
26 checks passed
GiteaBot pushed a commit to GiteaBot/gitea that referenced this pull request Sep 22, 2024
The previous implementation requires admin permission to rename branches
which should be write permission.

Fix go-gitea#31993
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Sep 22, 2024
@GiteaBot GiteaBot added the backport/done All backports for this PR have been created label Sep 22, 2024
lunny added a commit that referenced this pull request Sep 22, 2024
Backport #32066 by @lunny

The previous implementation requires admin permission to rename branches
which should be write permission.

Fix #31993

Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
zjjhot added a commit to zjjhot/gitea that referenced this pull request Sep 23, 2024
* giteaofficial/main:
  [skip ci] Updated licenses and gitignores
  Fix rename branch permission bug (go-gitea#32066)
  Fix artifact v4 upload above 8MB (go-gitea#31664)
  [skip ci] Updated translations via Crowdin
  Add bin to Composer Metadata (go-gitea#32099)
  Fix wrong last modify time (go-gitea#32102)
  Fix upload maven pacakge parallelly (go-gitea#31851)
  Repo Activity: count new issues that were closed (go-gitea#31776)
  Count typescript files as frontend for labeling (go-gitea#32088)
  Use camo.Always instead of camo.Allways (go-gitea#32097)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/done All backports for this PR have been created backport/v1.22 This PR should be backported to Gitea 1.22 lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/go Pull requests that update Go code modifies/templates This PR modifies the template files size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Team members can't rename branch but adding and deletion is possible
5 participants