let limit and offset use bind parameter #6806
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @jasonchuan thank you for your pr, can you please fix those failed tests? |
ok I'll fix those later! |
…e added a wrong one called pgx.QueryExecModeSimpleProtocol , causing the SQL with limit problem need 1 parameter ,but given two.
3 tasks
|
@jinzhu got the job done , please approve the postgress commit (go-gorm/postgres#239) first. because the stmt.Vars is polluted by gorm.io/driver/postgres@v1.5.4/migrator.go:598 ,we must get the vars ok for bindvar method of postgress driver first. |
a631807682
approved these changes
Feb 2, 2024
saeidee
reviewed
Feb 4, 2024
saeidee
approved these changes
Feb 5, 2024
|
Hi @jasonchuan, thanks for PR. But can I ask one more thing? Is the change |
iTanken
added a commit
to godoes/gorm-oracle
that referenced
this pull request
Feb 18, 2024
Ref: go-gorm/gorm/pull/6806 Signed-off-by: liutianqi <zixizixi@vip.qq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What did this pull request do?
two changes for solving the limt and offset problem which is possible to cause continuously increasing of prepared_stmt_count of mysql , max_prepared_stmt_count value range is 0 - 1048576 and default 16382.
User Case Description
the caller used while true ugly code to call our api , our api has bugs for no checking if the limit and offset is below the total row number . limit and offset was going far away from the row count . a number of sql would be prepared in mysql ,much more than max_prepared_stmt_count .
FATAL: MySQL error: 1461 "Can't create more than max_prepared_stmt_count statements (current value: 1048576 )"