let gorm support limit and offset binding parameters,change the BindVar of postgres driver #239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
if limit and offset use the parameter in new gorm version，must remove config vars before bindvar to ,and then restore them.
|
@jinzhu please approve this commit first and add a tag for this version |
3 tasks
a631807682
reviewed
Jan 31, 2024
jasonchuan
changed the title
a631807682
reviewed
Feb 1, 2024
a631807682
approved these changes
Feb 2, 2024
jinzhu
reviewed
Feb 4, 2024
postgres.go
Outdated
| index := 0 | ||
| varLen := len(stmt.Vars) | ||
| if varLen > 0 { | ||
| switch stmt.Vars[index].(type) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if limit and offset use the parameter in new gorm version，must remove config vars before bindvar to ,and then restore them.
What did this pull request do?
User Case Description
this is necessary for limit and offset binding parameters issue
go-gorm/gorm#6806