Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

website/integrations: nextcloud: add tip to solve hashed groups configuring OAuth2 #9153

Merged
merged 3 commits into from
Apr 11, 2024

Conversation

lucaam
Copy link
Contributor

@lucaam lucaam commented Apr 5, 2024

Details

I followed the docs to setup OAuth2 on Nextcloud and I got hashed group as result.

Image

Unchecking the option Use unique user ID

Image
Image
I had to play a bit to figure this out and it is not mentioned so I think it is useful to add the guidance to users that are trying to set OAuth2 configuration on Nextcloud.

Checklist

  • Local tests pass (ak test authentik/)
  • The code has been formatted (make lint-fix)

If an API change has been made

  • The API schema has been updated (make gen-build)

If changes to the frontend have been made

  • The code has been formatted (make web)

If applicable

  • The documentation has been updated
  • The documentation has been formatted (make website)

Signed-off-by: Luca Amoriello <luca.amoriello@hotmail.it>
@lucaam lucaam requested a review from a team as a code owner April 5, 2024 13:53
Copy link

netlify bot commented Apr 5, 2024

Deploy Preview for authentik-storybook canceled.

Name Link
🔨 Latest commit d7aa333
🔍 Latest deploy log https://app.netlify.com/sites/authentik-storybook/deploys/66105fa5f68ec400080102b1

Copy link

netlify bot commented Apr 5, 2024

Deploy Preview for authentik-docs ready!

Name Link
🔨 Latest commit d7aa333
🔍 Latest deploy log https://app.netlify.com/sites/authentik-docs/deploys/66105fa5a7aa94000862c612
😎 Deploy Preview https://deploy-preview-9153--authentik-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@tanberry tanberry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @lucaam for this helpful tip. Pease review my suggested wording, and make sure it still says what you intended before accepting the suggestion.

@tanberry
Copy link
Contributor

tanberry commented Apr 5, 2024

It also looks like you will need to run make website before pushing further commits to the PR... the lint-prettier check is failing in the build process. Let us know if you have any questions!

Copy link

codecov bot commented Apr 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.31%. Comparing base (cef1d2d) to head (d7aa333).
Report is 543 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #9153       +/-   ##
===========================================
+ Coverage   46.62%   92.31%   +45.69%     
===========================================
  Files         626      642       +16     
  Lines       30996    31637      +641     
===========================================
+ Hits        14451    29207    +14756     
+ Misses      16545     2430    -14115     
Flag Coverage Δ
e2e 50.60% <ø> (+5.88%) ⬆️
integration 26.24% <ø> (+0.25%) ⬆️
unit 89.69% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

lucaam and others added 2 commits April 5, 2024 22:26
Co-authored-by: Tana M Berry <tanamarieberry@yahoo.com>
Signed-off-by: Luca Amoriello <luca.amoriello@hotmail.it>
@lucaam
Copy link
Contributor Author

lucaam commented Apr 5, 2024

@tanberry Thanks for the suggestion, I think is way better now. I also executed make website to properly lint the code!

@rissson rissson changed the title Add tip to solve hashed groups configuring OAuth2 on Nextcloud website/integrations: nextcloud: add tip to solve hashed groups configuring OAuth2 Apr 8, 2024
@lucaam lucaam requested a review from tanberry April 9, 2024 07:31
Copy link
Contributor

@tanberry tanberry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @lucaam !

@tanberry tanberry merged commit 0ea1c8f into goauthentik:main Apr 11, 2024
59 of 64 checks passed
kensternberg-authentik added a commit that referenced this pull request Apr 12, 2024
* main:
  website/docs: ensure yaml code blocks have language tags (#9240)
  blueprints: only create default brand if no other default brand exists (#9222)
  web: bump API Client version (#9239)
  website/integrations: portainer: Fix Redirect URL mismatch (#9226)
  api: fix authentication schema (#9238)
  translate: Updates for file web/xliff/en.xlf in zh_CN (#9229)
  translate: Updates for file web/xliff/en.xlf in zh-Hans (#9230)
  translate: Updates for file locale/en/LC_MESSAGES/django.po in zh_CN (#9228)
  translate: Updates for file locale/en/LC_MESSAGES/django.po in zh-Hans (#9231)
  core: bump pydantic from 2.6.4 to 2.7.0 (#9232)
  core: bump ruff from 0.3.5 to 0.3.7 (#9233)
  web: bump @sentry/browser from 7.109.0 to 7.110.0 in /web in the sentry group (#9234)
  website: bump @types/react from 18.2.75 to 18.2.77 in /website (#9236)
  core, web: update translations (#9225)
  website/integrations: add pfSense search scope (#9221)
  core: bump idna from 3.6 to 3.7 (#9224)
  website/docs: add websocket support to nginx snippets (#9220)
  internal: add tests to go flow executor (#9219)
  website/integrations: nextcloud: add tip to solve hashed groups configuring OAuth2 (#9153)
  website/integrations: Jenkins, fix bolding (#9217)
kensternberg-authentik added a commit that referenced this pull request Apr 16, 2024
* main: (21 commits)
  web: manage stacked modals with a stack (#9193)
  website/docs: ensure yaml code blocks have language tags (#9240)
  blueprints: only create default brand if no other default brand exists (#9222)
  web: bump API Client version (#9239)
  website/integrations: portainer: Fix Redirect URL mismatch (#9226)
  api: fix authentication schema (#9238)
  translate: Updates for file web/xliff/en.xlf in zh_CN (#9229)
  translate: Updates for file web/xliff/en.xlf in zh-Hans (#9230)
  translate: Updates for file locale/en/LC_MESSAGES/django.po in zh_CN (#9228)
  translate: Updates for file locale/en/LC_MESSAGES/django.po in zh-Hans (#9231)
  core: bump pydantic from 2.6.4 to 2.7.0 (#9232)
  core: bump ruff from 0.3.5 to 0.3.7 (#9233)
  web: bump @sentry/browser from 7.109.0 to 7.110.0 in /web in the sentry group (#9234)
  website: bump @types/react from 18.2.75 to 18.2.77 in /website (#9236)
  core, web: update translations (#9225)
  website/integrations: add pfSense search scope (#9221)
  core: bump idna from 3.6 to 3.7 (#9224)
  website/docs: add websocket support to nginx snippets (#9220)
  internal: add tests to go flow executor (#9219)
  website/integrations: nextcloud: add tip to solve hashed groups configuring OAuth2 (#9153)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants