Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

website/integrations: portainer: Fix Redirect URL mismatch #9226

Merged
merged 1 commit into from
Apr 12, 2024
Merged

website/integrations: portainer: Fix Redirect URL mismatch #9226

merged 1 commit into from
Apr 12, 2024

Conversation

MisterrrX
Copy link
Contributor

@MisterrrX MisterrrX commented Apr 12, 2024

Details

Without the "/" the given configuration doesn't work, because the Redirect URLs in Portainer and the Portainer Provider in Authentik don't match.

Checklist

  • Local tests pass (ak test authentik/)
  • The code has been formatted (make lint-fix)

If an API change has been made

  • The API schema has been updated (make gen-build)

If changes to the frontend have been made

  • The code has been formatted (make web)

If applicable

  • The documentation has been updated
  • The documentation has been formatted (make website)

Signed-off-by: MisterrrX <101521000+MisterrrX@users.noreply.github.com>
@MisterrrX MisterrrX requested a review from a team as a code owner April 12, 2024 00:49
Copy link

netlify bot commented Apr 12, 2024

Deploy Preview for authentik-storybook canceled.

Name Link
🔨 Latest commit fa26ed4
🔍 Latest deploy log https://app.netlify.com/sites/authentik-storybook/deploys/6618850b5cff6e000876e8c5

Copy link

netlify bot commented Apr 12, 2024

Deploy Preview for authentik-docs ready!

Name Link
🔨 Latest commit fa26ed4
🔍 Latest deploy log https://app.netlify.com/sites/authentik-docs/deploys/6618850b99df46000820e4e3
😎 Deploy Preview https://deploy-preview-9226--authentik-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Apr 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.42%. Comparing base (ab3f0b5) to head (fa26ed4).
Report is 9 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9226      +/-   ##
==========================================
- Coverage   92.43%   92.42%   -0.01%     
==========================================
  Files         646      646              
  Lines       31985    31985              
==========================================
- Hits        29565    29562       -3     
- Misses       2420     2423       +3     
Flag Coverage Δ
e2e 50.35% <ø> (-0.02%) ⬇️
integration 26.29% <ø> (ø)
unit 89.82% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BeryJu BeryJu merged commit 45de247 into goauthentik:main Apr 12, 2024
60 of 65 checks passed
kensternberg-authentik added a commit that referenced this pull request Apr 12, 2024
* main:
  website/docs: ensure yaml code blocks have language tags (#9240)
  blueprints: only create default brand if no other default brand exists (#9222)
  web: bump API Client version (#9239)
  website/integrations: portainer: Fix Redirect URL mismatch (#9226)
  api: fix authentication schema (#9238)
  translate: Updates for file web/xliff/en.xlf in zh_CN (#9229)
  translate: Updates for file web/xliff/en.xlf in zh-Hans (#9230)
  translate: Updates for file locale/en/LC_MESSAGES/django.po in zh_CN (#9228)
  translate: Updates for file locale/en/LC_MESSAGES/django.po in zh-Hans (#9231)
  core: bump pydantic from 2.6.4 to 2.7.0 (#9232)
  core: bump ruff from 0.3.5 to 0.3.7 (#9233)
  web: bump @sentry/browser from 7.109.0 to 7.110.0 in /web in the sentry group (#9234)
  website: bump @types/react from 18.2.75 to 18.2.77 in /website (#9236)
  core, web: update translations (#9225)
  website/integrations: add pfSense search scope (#9221)
  core: bump idna from 3.6 to 3.7 (#9224)
  website/docs: add websocket support to nginx snippets (#9220)
  internal: add tests to go flow executor (#9219)
  website/integrations: nextcloud: add tip to solve hashed groups configuring OAuth2 (#9153)
  website/integrations: Jenkins, fix bolding (#9217)
kensternberg-authentik added a commit that referenced this pull request Apr 16, 2024
* main: (21 commits)
  web: manage stacked modals with a stack (#9193)
  website/docs: ensure yaml code blocks have language tags (#9240)
  blueprints: only create default brand if no other default brand exists (#9222)
  web: bump API Client version (#9239)
  website/integrations: portainer: Fix Redirect URL mismatch (#9226)
  api: fix authentication schema (#9238)
  translate: Updates for file web/xliff/en.xlf in zh_CN (#9229)
  translate: Updates for file web/xliff/en.xlf in zh-Hans (#9230)
  translate: Updates for file locale/en/LC_MESSAGES/django.po in zh_CN (#9228)
  translate: Updates for file locale/en/LC_MESSAGES/django.po in zh-Hans (#9231)
  core: bump pydantic from 2.6.4 to 2.7.0 (#9232)
  core: bump ruff from 0.3.5 to 0.3.7 (#9233)
  web: bump @sentry/browser from 7.109.0 to 7.110.0 in /web in the sentry group (#9234)
  website: bump @types/react from 18.2.75 to 18.2.77 in /website (#9236)
  core, web: update translations (#9225)
  website/integrations: add pfSense search scope (#9221)
  core: bump idna from 3.6 to 3.7 (#9224)
  website/docs: add websocket support to nginx snippets (#9220)
  internal: add tests to go flow executor (#9219)
  website/integrations: nextcloud: add tip to solve hashed groups configuring OAuth2 (#9153)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants