-
Notifications
You must be signed in to change notification settings - Fork 380
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Soft evict when hyperallocation of ext resource #200
Soft evict when hyperallocation of ext resource #200
Conversation
…tion_of_ext_resource
@@ -0,0 +1,9 @@ | |||
apiVersion: ensurance.crane.io/v1alpha1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Put this file in crane/examples/ensurance
@@ -0,0 +1,20 @@ | |||
apiVersion: ensurance.crane.io/v1alpha1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Put this file in crane/examples/ensurance
How to deal with the relationship between eviction-extresource and evict. For other actions, we decide how many pod should be actioned in executor module to reach the water line, in eviction-extresource this process prepend to analyzer module, should be consistent with other actions |
deletePath := map[string]interface{}{ | ||
"metadata": map[string]interface{}{ | ||
"labels": map[string]interface{}{ | ||
deleteLabel: "true", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add a label here, what's the next action, may be eviction is better and generic?
deleteLabel := "gocrane.io/specified-delete" | ||
if ref != nil { | ||
if ref.Kind == "CloneSet" { | ||
deleteLabel = "apps.kruise.io/specified-delete" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A customized logic? please delete it
fixed in #222 |
What this PR does / why we need it:
Soft evict when hyperallocation of ext resource