Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The cpu that can't reclaimed need add cpu idle of ExclusiveCpuSet #222

Merged
merged 3 commits into from
Apr 25, 2022
Merged

The cpu that can't reclaimed need add cpu idle of ExclusiveCpuSet #222

merged 3 commits into from
Apr 25, 2022

Conversation

shijieqin
Copy link
Collaborator

@shijieqin shijieqin commented Mar 21, 2022 •
edited
Loading

What this PR does / why we need it:

  1. The crane-agent creates the tsp when it starts, and the Node Resource Manager only uses the data of the tsp itself.
  2. Node resource manager use local data and tsp data.
  3. Configurable percent for idle resource reallocation. Configurable percent for idle resource reallocation #134
  4. Add nodelocal metric exclusive_cpu_idle
  5. The cpu that can't reclaimed need add cpu idle of ExclusiveCpuSet

szy441687879
szy441687879 reviewed Mar 22, 2022
View reviewed changes
cmd/crane-agent/app/agent.go Show resolved Hide resolved
pkg/agent/agent.go Outdated Show resolved Hide resolved
pkg/agent/agent.go Outdated Show resolved Hide resolved
pkg/ensurance/collector/cadvisor/cadvisor_linux.go Outdated Show resolved Hide resolved
pkg/ensurance/collector/cadvisor/cadvisor_unsupported.go Show resolved Hide resolved
pkg/resource/node_resource_manager.go Outdated Show resolved Hide resolved
pkg/agent/agent.go Show resolved Hide resolved
pkg/resource/node_resource_manager.go Outdated Show resolved Hide resolved
pkg/resource/node_resource_manager.go Show resolved Hide resolved
@qmhu
Copy link
Member

qmhu commented Mar 24, 2022

Please squash commits before the pr merged

@shijieqin shijieqin closed this Mar 25, 2022
@shijieqin shijieqin deleted the Cannot_reclaim_cpu_need_add_cpu_idle_of_ExclusiveCpuSet branch March 25, 2022 04:02
@shijieqin shijieqin restored the Cannot_reclaim_cpu_need_add_cpu_idle_of_ExclusiveCpuSet branch March 25, 2022 04:03
@shijieqin shijieqin reopened this Mar 25, 2022
@shijieqin
Modify the compute logic for CPUs that cannot be reused, and NodeReso…
245428a 
…urceManager will use both local and tsp data
@shijieqin shijieqin force-pushed the Cannot_reclaim_cpu_need_add_cpu_idle_of_ExclusiveCpuSet branch from 5ad8600 to 245428a Compare March 25, 2022 04:18
@shijieqin
Copy link
Collaborator Author

Please squash commits before the pr merged

fine!

yan234280533
yan234280533 reviewed Mar 25, 2022
View reviewed changes
pkg/resource/node_resource_manager.go Outdated Show resolved Hide resolved
pkg/agent/agent.go Outdated Show resolved Hide resolved
pkg/agent/agent.go Outdated Show resolved Hide resolved
pkg/agent/agent.go Show resolved Hide resolved
pkg/agent/agent.go Outdated Show resolved Hide resolved
pkg/agent/agent.go Outdated Show resolved Hide resolved
pkg/agent/agent.go Outdated Show resolved Hide resolved
pkg/agent/agent.go Outdated Show resolved Hide resolved
pkg/agent/agent.go Outdated Show resolved Hide resolved
pkg/agent/agent.go Outdated Show resolved Hide resolved
yan234280533
yan234280533 reviewed Mar 25, 2022
View reviewed changes
pkg/ensurance/collector/nodelocal/cpu.go Outdated Show resolved Hide resolved
pkg/ensurance/cm/advanced_cpu_manager.go Show resolved Hide resolved
pkg/resource/node_resource_manager.go Outdated Show resolved Hide resolved
yan234280533
yan234280533 reviewed Mar 25, 2022
View reviewed changes
cmd/crane-agent/app/options/option.go Outdated Show resolved Hide resolved
pkg/agent/agent.go Outdated Show resolved Hide resolved
pkg/utils/string.go Show resolved Hide resolved
yan234280533
yan234280533 reviewed Apr 21, 2022
View reviewed changes
pkg/ensurance/collector/nodelocal/cpu.go Outdated Show resolved Hide resolved
pkg/agent/agent.go Show resolved Hide resolved
pkg/agent/agent.go Outdated Show resolved Hide resolved
pkg/agent/agent.go Show resolved Hide resolved
pkg/agent/agent.go Show resolved Hide resolved
@shijieqin shijieqin force-pushed the Cannot_reclaim_cpu_need_add_cpu_idle_of_ExclusiveCpuSet branch from 09bd549 to 6089ed3 Compare April 21, 2022 12:21
@shijieqin
crane-agent only create tsp
aa85501 
Change the units of ext-cpu
@shijieqin shijieqin force-pushed the Cannot_reclaim_cpu_need_add_cpu_idle_of_ExclusiveCpuSet branch from 6089ed3 to aa85501 Compare April 21, 2022 12:28
@yan234280533
Copy link
Contributor

/LGTM

@yan234280533 yan234280533 merged commit 47d9cca into gocrane:main Apr 25, 2022
@mfanjie mfanjie mentioned this pull request Aug 11, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qmhu qmhu qmhu left review comments

@yan234280533 yan234280533 yan234280533 left review comments

@szy441687879 szy441687879 szy441687879 left review comments

@chenkaiyue chenkaiyue Awaiting requested review from chenkaiyue

@mfanjie mfanjie Awaiting requested review from mfanjie

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@shijieqin @qmhu @yan234280533 @szy441687879