Use external Wikipedia CC licensed images in block examples #1106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AnthonyLedesma
added
[Type] Enhancement
AnthonyLedesma
requested review from
EvanHerman,
jrtashjian and
richtabor
as code owners
|
Adding examples will override the style panel preview. So if we set example images in the Collage Gallery block, those images will show in the Styles panel preview rather than the ones uploaded. (Related comment) @richtabor is this the behavior we want?
|
|
I think it’s fine for galleries as it adds value to see what it actually looks like. |
|
@jrtashjian Do you know if core is tracking this as a bug? |
|
I'm not sure if they are but I was going to submit one if I couldn't find one. It's on my todo list. If we're ok with this behavior then I approve. |
jrtashjian
approved these changes
Nov 12, 2019
|
I'll merge this after I deploy our next release today so it goes into the following release. |
jrtashjian
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request uses images from https://commons.wikimedia.org/wiki/Main_Page just as core blocks have done. Used lower resolution images for the examples to help with load times.