-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use external Wikipedia CC licensed images in block examples #1106
Conversation
Adding examples will override the style panel preview. So if we set example images in the Collage Gallery block, those images will show in the Styles panel preview rather than the ones uploaded. (Related comment) @richtabor is this the behavior we want? |
I think it’s fine for galleries as it adds value to see what it actually looks like. |
@jrtashjian Do you know if core is tracking this as a bug? |
I'm not sure if they are but I was going to submit one if I couldn't find one. It's on my todo list. If we're ok with this behavior then I approve. |
I'll merge this after I deploy our next release today so it goes into the following release. |
This pull request uses images from https://commons.wikimedia.org/wiki/Main_Page just as core blocks have done. Used lower resolution images for the examples to help with load times.