Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Examples: Update example images with those from WP core. #1134

Merged
merged 4 commits into from
Nov 21, 2019

Conversation

kwight
Copy link
Contributor

@kwight kwight commented Nov 14, 2019

#1106 introduced WikiMedia images with non-GPL-compatible licenses. This PR swaps them out for WordPress core's own Public Domain example images, which are all hosted on the WP.org CDN.

In WordPress/gutenberg#17493, @jasmussen also points out https://commons.wikimedia.org/wiki/Featured_Pictures_in_the_Public_Domain, giving CoBlocks other options to this PR too.

These images are all licensed under one form or another of the CC Attribution-based licenses, meaning "You must give appropriate credit, provide a link to the license, and indicate if changes were made."

These images were actually fine, being Public Domain:

Testing Instructions

  • Apply this branch to a local testing install.
  • Open a new post.
  • Using the top toolbar inserter, enter the CoBlocks subsections and hover over the galleries, Media Card, and Author blocks.
  • Verify the example images all appear fine.

@jasmussen
Copy link

An always on the table option is, of course, to take your own photos and release them as GPL V2 or Public Domain, in case the somewhat sober selection on WikiMedia is unimpressive.

Copy link
Member

@AnthonyLedesma AnthonyLedesma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kwight Thank you for taking the time to put this request in. The images are perfectly acceptable for this iteration. Approved.

Copy link
Contributor

@richtabor richtabor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff!

@richtabor richtabor merged commit 745ca50 into godaddy-wordpress:master Nov 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants