-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix CoBlocks for Gutenberg 7.2.0: replace legacy editor- classes with block-editor- #1242
Fix CoBlocks for Gutenberg 7.2.0: replace legacy editor- classes with block-editor- #1242
Conversation
It is marked as "Needs Dev Note", which by the backwards compatibility guidelines is meant as an indication of needing to publish an associated In other words: It is expected that a migration guide would be authored as part of an upcoming major WordPress release in which it's expected to land. As to how this relates to interoperability between the Gutenberg plugin and other plugins... I'm not sure there are guidelines or expectations around this. The Gutenberg plugin is tended to be considered as being more unstable in its changing APIs, but even then it's typically tended to have some deprecation period (at least for breaking API changes). I can see how this might be an area for workflow improvement. I might imagine it could be something where the dev-notes associated with a "Needs Dev Notes" pull request should be authored at the time of the pull request, and should ideally be shared as part of a plugin release post and/or the tagging of the plugin release candidate. Third-party integrators may also consider using "Needs Dev Note" as a label filter for potential future compatibility issues. cc @youknowriad |
There was also this note published for dev-notes of WordPress 5.2:
https://make.wordpress.org/core/2019/04/09/the-block-editor-javascript-module-in-5-2/ (emphasis mine) |
Worth noting there are a few more of these set to land as part of WordPress/gutenberg#19489 . It shouldn't be a problem if this pull request captured all of those legacy class names. |
Appreciate it @aduth, I double-checked against that PR. Thanks! |
Gutenberg 7.2.0 has removed the legacy
editor-
classes in WordPress/gutenberg#19050 breaking the CoBlocks styles. This PR updates all those classes to use theblock-editor-
prefix.Screenshots
How to test