Block Editor: Remove (more) legacy "editor-" class name compatibility

[aduth]

Previously: #19050

This pull request seeks to remove more instances of editor--prefixed legacy className compatibility.

These fall under one of two reasons for not having been included as part of #19050:

• The classes were assigned to components in such a way that they violated CSS naming guidelines, where the classes were used in packages or components where they were not appropriate to be used (i.e. not in block-editor, or not consistent with the containing directory name).
• The classes were reintroduced in subsequent merges, in some cases in similar violation of the first point (see Link images in media + text #18139 (comment), a11y: Add aria-label attributes and custom override control to core/social-link block #18651 (comment))

Implementation Notes:

In the case of block-editor-block-settings-menu__control, the use was quite widespread, and it turned out that there are no styles or tests which reference this class name. For this reason, it was simply removed altogether.

Testing Instructions:

Verify there are no regressions in affected components (block options menu items, link editing form).

[youknowriad]

The test failure seems independent and already taken care of.