Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix content stripping due to Highlight block raw transform #2563

Merged
merged 1 commit into from
Aug 25, 2023

Conversation

AnthonyLedesma
Copy link
Member

Description

The raw transforms definition is traced to be the issue causing the stripping of HTML markup from paste contents. It seems that at some point the editor transforms stopped working as expected. Our Jest tests continued to pass however giving us a false sense of validation. The tests continued to pass until I removed the transform definition. That might indicate a change in approach for how Core does raw transforms, our tests for raw transforms likely need updating.

We used a core function to determine which markup to keep. getPhrasingContentSchema
Seemingly at some point, the raw transforms started to diverge from the given schema and instead targeted all pasted content.

Screenshots

pastingContent

Types of changes

Removal of a non-functional raw transform definition.
Disable of raw transform test specifically related to this logic.

How has this been tested?

Tested manually in the editor.

Acceptance criteria

Should be able to post formatted content into the editor.

Checklist:

  • My code is tested
  • My code follows accessibility standards
  • My code has proper inline documentation
  • I've included any necessary tests
  • I've included developer documentation
  • I've added proper labels to this pull request

@AnthonyLedesma AnthonyLedesma added [Priority] Critical This issue/pull request needs resolving immediately, likely followed by a hot-fix [Status] Needs Review Tracking pull requests that need another set of eyes labels Aug 24, 2023
@AnthonyLedesma AnthonyLedesma self-assigned this Aug 24, 2023
@jrtashjian jrtashjian merged commit 34b545a into master Aug 25, 2023
197 of 199 checks passed
@jrtashjian jrtashjian deleted the fix-formatting-removal-highlight-block branch August 25, 2023 01:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Priority] Critical This issue/pull request needs resolving immediately, likely followed by a hot-fix [Status] Needs Review Tracking pull requests that need another set of eyes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants