Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include a .gdignore #522

Closed
Zylann opened this issue Feb 27, 2021 · 4 comments · Fixed by #974
Closed

Include a .gdignore #522

Zylann opened this issue Feb 27, 2021 · 4 comments · Fixed by #974
Labels
enhancement This is an enhancement on the current functionality

Comments

@Zylann
Copy link
Collaborator

Zylann commented Feb 27, 2021

When godot-cpp is added as a submodule in a Godot project, Godot will wrongly try to import .obj compilation files and lock for a very long time because of it.

The solution is usually to add a .gdignore to prevent Godot from importing anything in there, but it's not possible for such integration to add that file because the submodule then becomes altered.
It is also inconvenient to put the .gdignore in the parent folder because it will also ignore things there that might need to be considered by Godot. In my project this makes my .gdns and .gdnlib unreachable in the editor.

So I think it would help to have a .gdignore already present in godot-cpp.
@Calinou Calinou added the enhancement This is an enhancement on the current functionality label Feb 27, 2021
@aaronfranke
Copy link
Member

An alternative solution is to store the godot-cpp submodule/folder outside of the Godot project, like in the current master of the GDNative demo projects. But yes, adding a .gdignore is a good idea.

@Xrayez
Copy link

Xrayez commented Aug 31, 2021 •
edited
Loading

Kind of similar to godotengine/godot#28343 (same problem with obj files)...

@furrykef
Copy link

I don't mean to be rude, but why is it taking nearly two years to add a single blank file to the repo?

@Calinou
Copy link
Member

Calinou commented Nov 16, 2022

I don't mean to be rude, but why is it taking nearly two years to add a single blank file to the repo?

Feel free to open a pull request for this 🙂

@akien-mga akien-mga mentioned this issue Dec 22, 2022
Merged
akien-mga added a commit to akien-mga/godot-cpp that referenced this issue Dec 22, 2022
@akien-mga
Add .gdignore file to godot-cpp, for use as submodule in Godot projects
854cb28 
.gdignore causes Godot to skip the folder when importing resources,
which is needed in particular to avoid importing compiled .obj files
from MSVC (which sadly share their extension with Waveform meshes).

Closes godotengine#522.
akien-mga added a commit to akien-mga/godot-cpp that referenced this issue Dec 22, 2022
@akien-mga
Add .gdignore file to godot-cpp, for use as submodule in Godot projects
f99aa47 
.gdignore causes Godot to skip the folder when importing resources,
which is needed in particular to avoid importing compiled .obj files
from MSVC (which sadly share their extension with Wavefront OBJ meshes).

Closes godotengine#522.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement This is an enhancement on the current functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add .gdignore file to godot-cpp, for use as submodule in Godot projects akien-mga/godot-cpp
5 participants
@Calinou @furrykef @Zylann @aaronfranke @Xrayez