Declare explicit specializations for CharStringT
#1265
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #1150.
I'm in the process of upgrading godot-cpp from 1009da4 to 3b3f357, and when compiling with clang-cl (and maybe regular Clang as well?) I seem to end up with the following compilation error:
From what I can tell it seems like it gets cranky over the fact that the specializations made for
CharStringT::get_data()
weren't declared first. Searching around a bit seems to support that this should be required, although the example shown there is a bit different.Weirdly enough it compiles just fine with latest MSVC. I haven't tried GCC, but I assume CI would have caught that already.
Anyway, this PR fixes this by simply declaring the specializations.