-
-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update input event tutorial to reflect recent changes #7330
Update input event tutorial to reflect recent changes #7330
Conversation
Note for merge: the upstream PR is not marked for cherrypick-4.0 and has to be considered 4.1 documentation. |
70c01c2
to
e32382c
Compare
@Sauermann Seeing the first PR got merged and included in 4.1, and the second one at this point will be 4.2+, does it make sense to merge this and cherry-pick to 4.1, then do another one if further changes are needed for 4.2+? |
@mhilbrunner That idea makes sense with respect to the content of the article. |
e32382c
to
d917eac
Compare
The other PR has been in circulation for two weeks now and got some testing. So I believe, that it is unlikely to be reverted. |
We can wait a bit more then merge. LGTM. |
Update input event flow graphic based on recent changes. Made some descriptions more precise. Input Event table: - Added missing InputEvents Gesture, MIDI and Shortcut - Removed unused Type Index column
d917eac
to
512a675
Compare
@Sauermann Merged, thanks for all this work! I guess for 4.1 a separate PR is easiest, backporting the relevant parts? |
Yes, that sounds about right. |
This PR updates the InputEvent tutorial
Update input event flow graphic to reflect the changes of
SubViewportContainer
event propagation aware of focused Control godot#79248Made some descriptions more precise.
Input Event table:
Updated 2023-08-05: include 4.2-changes