Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update input event tutorial to reflect recent changes #7330

Merged
merged 1 commit into from
Aug 22, 2023

Conversation

Sauermann
Copy link
Contributor

@Sauermann Sauermann commented May 10, 2023

This PR updates the InputEvent tutorial

Update input event flow graphic to reflect the changes of

Input Event table:

  • Added missing InputEvents Gesture, MIDI and Shortcut
  • Removed unused Type Index column

Updated 2023-08-05: include 4.2-changes

@Piralein Piralein added enhancement area:manual Issues and PRs related to the Manual/Tutorials section of the documentation labels May 11, 2023
@Piralein
Copy link
Member

Note for merge: the upstream PR is not marked for cherrypick-4.0 and has to be considered 4.1 documentation.

@Piralein Piralein added this to the 4.1 milestone May 17, 2023
@mhilbrunner
Copy link
Member

@Sauermann Seeing the first PR got merged and included in 4.1, and the second one at this point will be 4.2+, does it make sense to merge this and cherry-pick to 4.1, then do another one if further changes are needed for 4.2+?

@Sauermann
Copy link
Contributor Author

@mhilbrunner That idea makes sense with respect to the content of the article.
However godotengine/godot#79248 will make it necessary to update the graphic again, which was my reason for waiting in order to keep the git-history small.

@Sauermann Sauermann modified the milestones: 4.1, 4.2 Aug 5, 2023
@Sauermann
Copy link
Contributor Author

The other PR has been in circulation for two weeks now and got some testing. So I believe, that it is unlikely to be reverted.
I have updated the PR with the necessary changes for that PR.

@mhilbrunner
Copy link
Member

We can wait a bit more then merge. LGTM.

Update input event flow graphic based on recent changes.
Made some descriptions more precise.

Input Event table:
- Added missing InputEvents Gesture, MIDI and Shortcut
- Removed unused Type Index column
@mhilbrunner mhilbrunner merged commit 0ea5759 into godotengine:master Aug 22, 2023
1 check passed
@mhilbrunner
Copy link
Member

@Sauermann Merged, thanks for all this work! I guess for 4.1 a separate PR is easiest, backporting the relevant parts?

@Sauermann Sauermann deleted the fix-inputevent-tutorial branch August 22, 2023 05:32
@Sauermann
Copy link
Contributor Author

Yes, that sounds about right.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:manual Issues and PRs related to the Manual/Tutorials section of the documentation enhancement
Projects
None yet
4 participants