Make SubViewportContainer event propagation aware of focused Control
#79248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sauermann
force-pushed
the
fix-svc-focus-propagation
branch
from
9db09f6
to
d5aa5bf
Compare
Sauermann
force-pushed
the
fix-svc-focus-propagation
branch
2 times, most recently
from
856950e
to
642dc4b
Compare
Propagate `InputEvents` without position either - during the Input-stage, when it has focus or - during the Unhandled-Input-stage, otherwise This makes sure that Gui-Input happens in the correct order. Move "Unhandled key Input" handling before "Unhandled Input" handling, so that Unicode input with Alt / Ctrl modifiers are sent to the nodes in the correct order. Change the default focus mode of `SubViewportContainer` from `FOCUS_NONE` to `FOCUS_CLICK`, to automatically remove focus from other `Control`-nodes, when clicking inside a `SubViewport`.
Sauermann
force-pushed
the
fix-svc-focus-propagation
branch
from
642dc4b
to
e6386bc
Compare
RandomShaper
approved these changes
Jul 19, 2023
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolve #79235
Regression from #58334
The fix for the linked issue consists of three changes:
InputEventswithout position eitherMove "Unhandled key Input" handling before "Unhandled Input" handling, so that Unicode input with Alt / Ctrl modifiers are sent to LineEdit-nodes in the correct order.
Change the default focus mode of
SubViewportContainerfromFOCUS_NONEtoFOCUS_CLICK, to automatically remove focus from otherControl-nodes, when clicking inside aSubViewport.Updated 2023-07-14: Change process groups only on focus change
Updated 2023-07-17: Fix Unicode input with Alt / Ctrl modifiers propagation order for nodes like LineEdit