Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Navigation] Document 3D support is required for navigation #9054

Merged
merged 1 commit into from
Mar 6, 2024

Conversation

AThousandShips
Copy link
Member

@AThousandShips AThousandShips commented Mar 5, 2024

Should only be cherry picked for 4.2 as this does not apply for 4.1

@mhilbrunner
Copy link
Member

It might be worth it to add a single sentence of why this is? The reasoning makes sense to me, but if you are new, this may come as a surprise and seem weird at first glance.

@AThousandShips
Copy link
Member Author

There really isn't a reason as such, see:

It was done as the code depends on the 3D side and at the time it failed to compile because of missing guards, so not sure what it should say other than that it depends on the 3D side which isn't enabled

@mhilbrunner
Copy link
Member

Well, "because there is no 2D navigation, and everything uses 3D navigation under the hood" IMO makes (some amount of) sense once you know that, and experienced people will probably infer that from that note, but I could see newer people being confused. Maybe not, I guess :)

@mhilbrunner
Copy link
Member

Thanks, and thanks for making the change!

@mhilbrunner mhilbrunner merged commit 8030047 into godotengine:master Mar 6, 2024
1 check passed
@AThousandShips AThousandShips deleted the no_3d_docs branch March 6, 2024 14:50
@AThousandShips
Copy link
Member Author

Thank you!

@mhilbrunner
Copy link
Member

Cherry-picked to 4.2 in #9647.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:contributing Issues and PRs related to the Contributing/Development section of the documentation enhancement topic:buildsystem
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Exporting 2d game with custom godot build that has disabled_3d=yes flag breaks navigation 2d.
3 participants