-
-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Navigation] Document 3D support is required for navigation #9054
Conversation
It might be worth it to add a single sentence of why this is? The reasoning makes sense to me, but if you are new, this may come as a surprise and seem weird at first glance. |
There really isn't a reason as such, see: It was done as the code depends on the 3D side and at the time it failed to compile because of missing guards, so not sure what it should say other than that it depends on the 3D side which isn't enabled |
Well, "because there is no 2D navigation, and everything uses 3D navigation under the hood" IMO makes (some amount of) sense once you know that, and experienced people will probably infer that from that note, but I could see newer people being confused. Maybe not, I guess :) |
e0d68fa
to
60fea0d
Compare
60fea0d
to
54a8d08
Compare
Thanks, and thanks for making the change! |
Thank you! |
Cherry-picked to 4.2 in #9647. |
Should only be cherry picked for 4.2 as this does not apply for 4.1