-
-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add macOS ARM64 (Apple Silicon) support. #60
Conversation
FWIW I'm using the dylib linked in the description on my M1 MacBook Pro and everything seems to be working correctly from what I've tested so far. |
And it looks like the godot-cpp repo has a PR that's been merged to add ARM support on macOS now? (different from the PR linked in this one's description) |
It is, but without godotengine/godot-cpp#587, there's no way to build both architectures without an extra hack (copying godot-cpp files around, to avoid it overwriting it). Also, it will need extra |
Should this PR be merged now? We can run the |
The scons option names added in https://github.com/godotengine/godot-cpp/pull/584/files seem to be different than the ones mentioned in this PR, but it doesn't seem hard to port these changes to suit the changes that were finally merged into godot-cpp because thanks to this PR we know where we need the architecture changes |
Updated to the last |
The current build failure in mac just seems to be related to using the build config argument that goes into build_libs_mac.sh. I guess it just needs to use $1 instead There is a catch here that $1 is documented to be |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot! I didn't have an M1 system but since people have already tested the builds, this helps a ton!
No description provided.