Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release Godot 4.2 stable and publish release notes #758

Merged
merged 2 commits into from
Nov 30, 2023
Merged

Release Godot 4.2 stable and publish release notes #758

merged 2 commits into from
Nov 30, 2023

Conversation

YuriSizov
Copy link
Contributor

What the title says 😎

@YuriSizov YuriSizov added topic:content Issues and PRs related to static content topic:blog New blogposts and corrections labels Nov 28, 2023
JohnVeness
JohnVeness reviewed Nov 28, 2023
View reviewed changes
collections/_article/godot-4-2-arrives-in-style.md Outdated Show resolved Hide resolved
collections/_article/godot-4-2-arrives-in-style.md Outdated Show resolved Hide resolved
collections/_article/godot-4-2-arrives-in-style.md Outdated Show resolved Hide resolved
collections/_article/godot-4-2-arrives-in-style.md Outdated Show resolved Hide resolved
collections/_article/godot-4-2-arrives-in-style.md Outdated Show resolved Hide resolved
collections/_article/godot-4-2-arrives-in-style.md Outdated Show resolved Hide resolved
@YuriSizov YuriSizov force-pushed the release-godot-4.2 branch 2 times, most recently from 59913a2 to 655790c Compare November 29, 2023 13:05
@YuriSizov
Copy link
Contributor Author

All feedback should be addressed (or I followed my own judgement if I felt it was more arbitrary). We also discussed the cover image a bit on the chat, and I updated it as well.

clayjohn
clayjohn reviewed Nov 29, 2023
View reviewed changes
Copy link
Member

@clayjohn clayjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work! There is a ton of content here and it is great.

I left a few suggestions to clean up some grammar issues and a few other small issues

collections/_article/godot-4-2-arrives-in-style.md Outdated Show resolved Hide resolved
collections/_article/godot-4-2-arrives-in-style.md Outdated Show resolved Hide resolved
collections/_article/godot-4-2-arrives-in-style.md Outdated Show resolved Hide resolved
collections/_article/godot-4-2-arrives-in-style.md Outdated Show resolved Hide resolved
akien-mga
akien-mga approved these changes Nov 30, 2023
View reviewed changes
Copy link
Member

@akien-mga akien-mga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me! Amazing work 🥇

@YuriSizov @akien-mga
Apply suggestions from code review
2d78163 
Co-authored-by: Rémi Verschelde <rverschelde@gmail.com>
@YuriSizov YuriSizov merged commit 08a8fe9 into godotengine:master Nov 30, 2023
1 check passed
@YuriSizov
Copy link
Contributor Author

Choo choo! Thanks for reviews, everyone, and thanks for all the contributions <3

@YuriSizov YuriSizov deleted the release-godot-4.2 branch November 30, 2023 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohnVeness JohnVeness JohnVeness left review comments

@clayjohn clayjohn clayjohn left review comments

@coppolaemilio coppolaemilio coppolaemilio approved these changes

@akien-mga akien-mga akien-mga approved these changes

@AThousandShips AThousandShips AThousandShips approved these changes

Assignees
No one assigned
Labels
topic:blog New blogposts and corrections topic:content Issues and PRs related to static content
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@YuriSizov @coppolaemilio @JohnVeness @akien-mga @clayjohn @AThousandShips