Merge pull request #90939 from AThousandShips/web_ver_fix

[Web] Fix building for web on Windows
godotengine · Apr 22, 2024 · 69811b9 · 69811b9
2 parents bfca90a + 173692d
commit 69811b9
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/methods.py b/methods.py
@@ -926,7 +926,11 @@ def get_compiler_version(env):
         # Not using -dumpversion as some GCC distros only return major, and
         # Clang used to return hardcoded 4.2.1: # https://reviews.llvm.org/D56803
         try:
-            version = subprocess.check_output([env.subst(env["CXX"]), "--version"]).strip().decode("utf-8")
+            version = (
+                subprocess.check_output([env.subst(env["CXX"]), "--version"], shell=(os.name == "nt"))
+                .strip()
+                .decode("utf-8")
+            )
         except (subprocess.CalledProcessError, OSError):
             print("Couldn't parse CXX environment variable to infer compiler version.")
             return ret