Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Web] Fix building for web on Windows #90939

Merged
merged 1 commit into from
Apr 22, 2024

Conversation

AThousandShips
Copy link
Member

@AThousandShips AThousandShips commented Apr 20, 2024

On Windows the command for emscripten are provided as .bat files, which causes the compiler version check to fail without shell=True

Shell version of the command works on Windows only, hence the check

If run on Windows without this change you get:

Couldn't parse CXX environment variable to infer compiler version.

And the version is set to just (-1, -1, -1), breaking any adjustments and fixes for the compiler

On Windows the command for emscripten are provided as `.bat` files,
which causes the compiler version check to fail without `shell=True`
@AThousandShips AThousandShips added bug platform:windows platform:web topic:buildsystem cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release labels Apr 20, 2024
@AThousandShips AThousandShips added this to the 4.3 milestone Apr 20, 2024
@AThousandShips AThousandShips requested a review from a team as a code owner April 20, 2024 12:25
@Jagholin
Copy link

huh would you look at that
does it also fix the dlink_enabled stuff?

@AThousandShips
Copy link
Member Author

AThousandShips commented Apr 21, 2024

It should, please try it out, it fixes the version check that's required

Edit: Tested and the error reported in #90983 doesn't happen with this, can't confirm that it works fully though as I don't have any project set up for it

@Jagholin
Copy link

I can confirm that this patch lets the web template compile on my system.
Unfortunately, after that the freshly built template doesn't work with gdextension modules for me :(
But it's likely a separate issue

@akien-mga akien-mga merged commit 69811b9 into godotengine:master Apr 22, 2024
16 checks passed
@AThousandShips AThousandShips deleted the web_ver_fix branch April 22, 2024 10:59
@akien-mga
Copy link
Member

Thanks!

@AThousandShips
Copy link
Member Author

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release platform:web platform:windows topic:buildsystem
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't build web export template with dlink_enabled
3 participants