Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error when creating physical skeleton in TPS demo #23920

Closed
akien-mga opened this issue Nov 23, 2018 · 4 comments · Fixed by #34029
Closed

Error when creating physical skeleton in TPS demo #23920

akien-mga opened this issue Nov 23, 2018 · 4 comments · Fixed by #34029
Assignees
Milestone

Comments

@akien-mga
Copy link
Member

akien-mga commented Nov 23, 2018

Godot version:
Current master (8ba0d51)

OS/device including version:
Mageia 7 x86_64

Issue description:
When selecting "Create Physical Skeleton" in the player.tscn's Skeleton of the TPS demo, the following error is printed:

ERROR: get_bone_parent: Index p_bone=-1 out of size (bones.size()=112)
   At: scene/3d/skeleton.cpp:481.
ERROR: erase: Condition ' !p_I ' is true. returned: false
   At: ./core/list.h:157.

Might be an issue with the model itself, but worth investigating nevertheless.

CC @AndreaCatania

Steps to reproduce:

  • Clone TPS demo and open it (import takes a while, maybe a simpler reproducer can be found) or use MRP below (only player.tscn with dae and .import folder, 100 MB)
  • Open player.tscn, select Skeleton, select "Create Physical Skeleton"
  • See console

Minimal reproduction project:
player.tscn scene only

@akien-mga
Copy link
Member Author

akien-mga commented Nov 23, 2018

I added a minimal reproduction project with only the player.tscn scene and its dae (and assets pre-imported), takes 100 MB. Will only be up for 7 days.

@akien-mga akien-mga modified the milestones: 3.1, 3.2 Jan 25, 2019
@TheMikirog
Copy link

The issue is still there and it appeared once I ported my project from 3.0 to 3.1
Again, no errors like it in 3.0. Doesn't seem to matter that much, since everything is working, but that error spam is really annoying.
Index p_bone=-1 out of size (bones.size()=16)

@AndreaCatania
Copy link
Contributor

I didn't checked the code yet, but seems a model problem. Who is managing this project?

@pouleyKetchoupp
Copy link
Contributor

The second error is fixed with #34028.

There was a bone attachment on one of the bones that was causing an error when trying to erase bound nodes on bones. For most of them it doesn't trigger the error because the list is empty, and an error was triggered for the only one with a bone attachment.

pouleyKetchoupp added a commit to nekomatata/godot that referenced this issue Nov 30, 2019
An error was systematically triggered on the root bone, when trying to access its parent (the return value wasn't used in this case anyway).

Fixes godotengine#23920
marstaik pushed a commit to marstaik/godot that referenced this issue Dec 24, 2019
An error was systematically triggered on the root bone, when trying to access its parent (the return value wasn't used in this case anyway).

Fixes godotengine#23920
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants