Removed errors when List::erase() can't find the value #34028
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not against it, but how catch situations when we're trying to erase something which doesn't exist? |
|
If we do want to catch all these situations, then it should be consistent and raise an error when the list is empty as well, and we'll have to fix these cases. |
|
@pouleyKetchoupp Is this still desired? If so, it needs to be rebased on the latest master branch. |
This change makes the behavior consistent when the value is not found between erasing from an empty list (no error, just returning false) and erasing from a non-empty list (previously displaying triggering an error and returning false). Error message previously triggered: ERROR: erase: Condition ' !p_I ' is true. returned: false At: ./core/list.h:157.
pouleyKetchoupp
force-pushed
the
list-erase-not-found
branch
from
cb1c3c8
to
45445e1
Compare
|
I think it's still relevant in order to make things consistent, just rebased on master. |
|
Thanks! |
Xrayez
added a commit
to goostengine/goost
that referenced
this pull request
Sep 13, 2020
For consistency with godotengine/godot#34028. Note that `erase` was renamed to `remove` in Goost.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change makes the behavior consistent when the value is not found between erasing from an empty list (no error, just returning false) and erasing from a non-empty list (previously triggering an error and returning false).
Error message previously triggered: