GDScript LSP parse_local_script() crashes the editor #39375
Milestone
Comments
|
Stacktrace from the Had to tweak the |
|
The original MRP is a bit evil as it's a tool script that tries to parse itself... but the same crash happens when parsing another script without circular reference. |
akien-mga
added a commit
to akien-mga/godot
that referenced
this issue
Jun 8, 2020
`latest_client_id` now defaults to `-1` (invalid ID) instead of `0`. Also fix typo in notification `gdscrip_client/changeWorkspace`, and fix argument names in method binds. Fixes godotengine#39375.
|
Will this be fixed in 3.2? Also is this a misuse? (there is no doc for it) The GDScript doc maker uses it, and I would really like to use that data source as well...
I don't see how that's a problem, it shouldnt be. It's not like I'm doing |
Yes, that's what this label means:
I think so, but I'm not familiar enough with this to confirm 100%. Reading the code, it seems The API should definitely be documented and improved further though. |
|
I can't find any place in this repo where Note I'm just interested to get the GDScript parsing data from within the Godot editor, not even trying to write a client/server thing. I've been looking for a way to get that data for a while, but so far it seems to remain behind an API meant for something else... |
|
Maybe @NathanLovato and @Razoric480 (who authored the GDQuest script) can weigh in. Maybe |
|
I can't really comment on this issue, despite me and Nathan working on the script that uses it; we never really encountered an issue with it, maybe because we specifically had used it in a way that it wouldn't reference itself (having the scripts in the root of the project, pointing to a specific directory) or because we run it from inside a launched editor instance. Either way, it was sheer happenstance rather than a deliberate bug avoidance. |
akien-mga
added a commit
to akien-mga/godot
that referenced
this issue
Jun 10, 2020
`latest_client_id` now defaults to `-1` (invalid ID) instead of `0`. Also fix typo in notification `gdscrip_client/changeWorkspace`, and fix argument names in method binds. Fixes godotengine#39375. (cherry picked from commit e34f337)
ChristopheLY
pushed a commit
to ChristopheLY/godot
that referenced
this issue
Jun 22, 2020
`latest_client_id` now defaults to `-1` (invalid ID) instead of `0`. Also fix typo in notification `gdscrip_client/changeWorkspace`, and fix argument names in method binds. Fixes godotengine#39375.
huhund
pushed a commit
to huhund/godot
that referenced
this issue
Nov 10, 2020
`latest_client_id` now defaults to `-1` (invalid ID) instead of `0`. Also fix typo in notification `gdscrip_client/changeWorkspace`, and fix argument names in method binds. Fixes godotengine#39375. (cherry picked from commit e34f337)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Godot 3.2.2 beta4
After reading how https://github.com/GDQuest/gdscript-docs-maker/blob/4c3020988c2542737abf467a7ae40d9f744e544c/godot-scripts/Collector.gd#L74 was written, I discovered there is an apparently undocumented access to GDScript language server, which I'd find very useful to have information about.
So I tried to grab that data and see what it provides, using a similar script. I used an
EditorPluginbecause that singleton doesn't exist in non-editor launches. Unfortunately, it crashes the editor when my script gets to callworkspace.parse_local_script(file).Test project:
GDScriptDocCrash.zip
Go to
ProjectSettingsand enable the plugin.The text was updated successfully, but these errors were encountered: