GDScript LSP: Fix crash in notify_client #39385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`latest_client_id` now defaults to `-1` (invalid ID) instead of `0`. Also fix typo in notification `gdscrip_client/changeWorkspace`, and fix argument names in method binds. Fixes godotengine#39375.
akien-mga
added
bug
topic:gdscript
cherrypick:3.x
|
Looks good to me |
|
Cherry-picked for 3.2.2. |
akien-mga
removed
the
cherrypick:3.x
akien-mga
added a commit
to akien-mga/godot
that referenced
this pull request
Jun 15, 2020
Reverts `latest_client_id` back to 0, as I misunderstood how the client IDs are assigned and, without further testing and debugging, I can't say if this was a bug or a valid default value. Similarly, a `latest_client_id` of -1 is no longer raising an error. Fixes godotengine#39548.
akien-mga
added a commit
that referenced
this pull request
Jun 15, 2020
GDScript LSP: Fix wrong error checks added in #39385
akien-mga
added a commit
that referenced
this pull request
Jun 15, 2020
Reverts `latest_client_id` back to 0, as I misunderstood how the client IDs are assigned and, without further testing and debugging, I can't say if this was a bug or a valid default value. Similarly, a `latest_client_id` of -1 is no longer raising an error. Fixes #39548. (cherry picked from commit 786f4ad)
ChristopheLY
pushed a commit
to ChristopheLY/godot
that referenced
this pull request
Jun 22, 2020
Reverts `latest_client_id` back to 0, as I misunderstood how the client IDs are assigned and, without further testing and debugging, I can't say if this was a bug or a valid default value. Similarly, a `latest_client_id` of -1 is no longer raising an error. Fixes godotengine#39548.
huhund
pushed a commit
to huhund/godot
that referenced
this pull request
Nov 10, 2020
Reverts `latest_client_id` back to 0, as I misunderstood how the client IDs are assigned and, without further testing and debugging, I can't say if this was a bug or a valid default value. Similarly, a `latest_client_id` of -1 is no longer raising an error. Fixes godotengine#39548. (cherry picked from commit 786f4ad)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
latest_client_idnow defaults to-1(invalid ID) instead of0.Also fix typo in notification
gdscrip_client/changeWorkspace,and fix argument names in method binds.
Fixes #39375.
CC @Geequlim @ofrank123 @NathanLovato - I just fixed the crash but I didn't check that it doesn't cause any issue with LSP clients.