OS move_to_trash() on Linux is not compliant with the Freedesktop specification

[chucklepie]

Godot version:
3.2.2 stable

OS/device including version:
Linux mint

Issue description:
In Godot modifying files externally is generally a bad idea as things may break inside Godot, so the approach is to use the IDE.

Unlike almost most IDEs, when you select DELETE on an item in the FileSystem dock they are removed permanently (yes, I know there is a message saying this), they are not removed to the current operating system Trash.

This is quite a dangerous thing and all other editors simply send the files to the Trash. I know this because I decided to tidy up some files before committing and accidentally deleted all the files I had created and worked on in the past few hours as I'd selected a couple by mistake.

Steps to reproduce:

1. create a file
2. Use Godot to delete it
3. No getting it back

[Calinou]

they are not removed to the current operating system Trash.

This is supposed to happen, but it's not working for some reason: #41263

It works here with Godot 3.2.3 and Fedora 32 KDE.

[chucklepie]

Right, time to apologise, but I think there's still a little bug ;)

Looks like what has happened is I didn't find the files because for some reason when I delete from Godot the Trash items do not have a timestamp and I was sorting by date. Is this a known thing? because deleting from everything else (e.g. file manager, vscode, graphics tools, etc) adds date/time but inside Godot the stamp is left out - I've just tested it and it's consistently doing this.

[Anutrix]

@chucklepie I suggest you rename the issue title.
Godot moves the deleted files to trash can using mv command (

godot/platform/linuxbsd/os_linuxbsd.cpp

Line 336 in 75e2a40

err = execute("mv", mv_args, true, nullptr, nullptr, &retval);

).
Not sure why the timestamps would be effected. It's most probably a file manager issue.

[akien-mga]

As seen in #41263, the problem is that our implementation of OS::move_to_trash() for Linux/*BSD (in platform/linuxbsd/os_linuxbsd.cpp) does not generate .trashinfo files that describe the trashed files and can be used to restore them.

The implementation should be reviewed to ensure that it follows the Freedesktop Trash specification.

Here's our relevant code:

godot/platform/linuxbsd/os_linuxbsd.cpp

Line 305 in 7a2d721

Error OS_LinuxBSD::move_to_trash(const String &p_path) {

[dalexeev]

The issue is still not fixed in 3.2.4.beta6.official.

[Calinou]

@dalexeev #44021 needs to be remade for the 3.2 branch to fix it there.