Fix implementation of move_to_trash() on Linux

[dakennedyd]

Modifies move_to_trash() on Linux
Fixes #42840 OS move_to_trash() on Linux is not compliant with the Freedesktop specification

[pouleyKetchoupp]

Nice work! See my comments for details, otherwise the code looks fine. I haven't tested though.

Are there known use cases for gio trash and gvfs-trash not supported? I wonder if we still need the manual fallback case at all.

[dakennedyd]

The gio/gvfs-trash functions seem to be part of the GNOME/GTK stack. I don't know if this commands work at all
on non GNOME systems, plus is nice to have a fallback.

[pouleyKetchoupp]

I've made some tests on Ubuntu/Gnome and it works fine with the 3 methods.

The only difference is in the manual fallback, the .trashinfo files use %2F for / characters (due to how Godot's http_escape works) while gio and gvfs-trash use /. It doesn't seem to be a problem though, the file information is displayed correctly in the trash.

[akien-mga]

Are there known use cases for gio trash and gvfs-trash not supported? I wonder if we still need the manual fallback case at all.

The gio/gvfs-trash functions seem to be part of the GNOME/GTK stack. I don't know if this commands work at all
on non GNOME systems, plus is nice to have a fallback.

I do have gio here on KDE Plasma, which is part of glib2.0, which is a common dependency for a lot of software regardless of the DE, so that's a fairly safe option.

That being said, KDE does have its own "io" client kioclient5:

  kioclient5 move 'src' 'dest'
            # Moves the URL 'src' to 'dest'.
            #   'src' may be a list of URLs.

            #   'dest' may be "trash:/" to move the files
            #   to the trash.

            #   the short version kioclient5 mv
            #   is also available.

Tested locally with:

kioclient5 move icon.png trash:/

And it seems to work fine.

I think KDE4 had kioclient (without 5), but I don't think we need to bother with KDE4 support anymore.
That being said the same holds true for gvfs-trash which seems to be deprecated now.

[akien-mga]

Could you add support for kioclient5 as suggested above? Then it should be good to merge.

I'd suggest this order:

• gio (glib)
• kioclient5 (KDE)
• gfvs-trash (Debian/Ubuntu-specific, deprecated)

[dakennedyd]

I did the changes you requested.

Sorry for the delay.

[akien-mga]

Thanks!

[akien-mga]

Cherry-picked for 3.4.