Multiword UWP Export Capabilities not added to AppxManifest.xml #47900
Labels
Milestone
Comments
akien-mga
added a commit
to akien-mga/godot
that referenced
this issue
Jun 17, 2021
…smatch The previous code used `camelcase_to_underscore` to prettify the names for display in the export preset, but it leads to inconsistencies if we don't make sure to do the reverse operation when writing to the `AppxManifest.xml`. It's simpler to keep the same names as in the manifest, which is also what users will see referenced in MS documentation. Fixes godotengine#47900. Co-authored-by: Rémi Verschelde <rverschelde@gmail.com>
akien-mga
pushed a commit
to akien-mga/godot
that referenced
this issue
Jun 29, 2021
…smatch The previous code used `camelcase_to_underscore` to prettify the names for display in the export preset, but it leads to inconsistencies if we don't make sure to do the reverse operation when writing to the `AppxManifest.xml`. It's simpler to keep the same names as in the manifest, which is also what users will see referenced in MS documentation. Fixes godotengine#47900. Co-authored-by: Rémi Verschelde <rverschelde@gmail.com> (cherry picked from commit c87e49d)
akien-mga
pushed a commit
to akien-mga/godot
that referenced
this issue
Jun 29, 2021
…smatch The previous code used `camelcase_to_underscore` to prettify the names for display in the export preset, but it leads to inconsistencies if we don't make sure to do the reverse operation when writing to the `AppxManifest.xml`. It's simpler to keep the same names as in the manifest, which is also what users will see referenced in MS documentation. Fixes godotengine#47900. Co-authored-by: Rémi Verschelde <rverschelde@gmail.com> (cherry picked from commit c87e49d)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Godot version:
3.3.rc9
OS/device including version:
Windows 10 build 19042.867
Issue description:
UWP Capabilities that are 2 or more words are not added to the generated AppxManifest.xml when exporting
Steps to reproduce:
Click on Projects -> Export -> UWP
Scroll down to Capabilities
check them all on
Export Project
Extract appx that was built as a zip file
Open AppxManifest.xml with a text editor
Look under
Note that all Capabilities that are only 1 word are there such as appointments, chat, contacts
But there are none that are 2 more words, such as All Joyn, Code Generation, Internet Client
Minimal reproduction project:
ExportPluginTest.zip
The problem is Windows format of the capabilities is camel case, ie internetClient.
platforms\uwp\export\export.cpp list these at the top of the file correctly, but then uses camelcase_to_underscore when adding to ExportOption list.
Then when it is generating AppxManifest.xml in _fix_manifest it looks for the original names, not the underscore name.
I am working on a pull request to fix this.
The text was updated successfully, but these errors were encountered: