UWP: Keep upstream names for capabilities preset settings to avoid mismatch #49680
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…smatch The previous code used `camelcase_to_underscore` to prettify the names for display in the export preset, but it leads to inconsistencies if we don't make sure to do the reverse operation when writing to the `AppxManifest.xml`. It's simpler to keep the same names as in the manifest, which is also what users will see referenced in MS documentation. Fixes godotengine#47900. Co-authored-by: Rémi Verschelde <rverschelde@gmail.com>
akien-mga
added
bug
platform:uwp
cherrypick:3.x
|
Cherry-picked for 3.4. |
akien-mga
removed
the
cherrypick:3.x
|
Cherry-picked for 3.3.3. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous code used
camelcase_to_underscoreto prettify the names fordisplay in the export preset, but it leads to inconsistencies if we don't make
sure to do the reverse operation when writing to the
AppxManifest.xml.It's simpler to keep the same names as in the manifest, which is also what
users will see referenced in MS documentation.
Fixes #47900.
Supersedes #47902.
Also, this doesn't seem to impact what gets shown to users in the Export Preset configuration dialog, where the property editor does apply
capitalizeanyway: