-
-
Notifications
You must be signed in to change notification settings - Fork 21.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Noticeable freeze after saving a scene #93104
Labels
Milestone
Comments
Hilderin
added a commit
to Hilderin/godot
that referenced
this issue
Jun 20, 2024
fire
pushed a commit
to V-Sekai/godot
that referenced
this issue
Jul 2, 2024
MewPurPur
pushed a commit
to MewPurPur/godot
that referenced
this issue
Jul 11, 2024
sorascode
pushed a commit
to sorascode/godot-soras-version
that referenced
this issue
Jul 22, 2024
Luis-Wong
pushed a commit
to Luis-Wong/godot
that referenced
this issue
Jul 26, 2024
2nafish117
pushed a commit
to 2nafish117/godot
that referenced
this issue
Aug 5, 2024
chryan
pushed a commit
to chryan/godot
that referenced
this issue
Aug 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Tested versions
Regression from #77932
System information
Windows 10.0.19045 - Vulkan (Forward+) - dedicated NVIDIA GeForce GTX 1060 (NVIDIA; 31.0.15.4633) - Intel(R) Core(TM) i7-7700HQ CPU @ 2.80GHz (8 Threads)
Issue description
I noticed that there is a noticeable editor freeze when saving a scene. I did some profiling and it turns out that when you save a scene, it causes EditorFileSystem update, which causes the FileSystem dock to... reload the whole tree.
While previously it wouldn't be that noticeble, it is after #77932.
Here's a comparison in a dev build.
With #77932
godot.windows.editor.dev.x86_64_tpRpT69keo.mp4
Without #77932
godot.windows.editor.dev.x86_64_nZFpWFZHIC.mp4
It's 3 times shorter. Maybe we wouldn't have freeze at all if the FileSystem dock did not decide to update for no reason.
Steps to reproduce
Minimal reproduction project (MRP)
N/A
The text was updated successfully, but these errors were encountered: