Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Noticeable freeze after saving a scene #93104

Closed
KoBeWi opened this issue Jun 12, 2024 · 0 comments · Fixed by #93147
Closed

Noticeable freeze after saving a scene #93104

KoBeWi opened this issue Jun 12, 2024 · 0 comments · Fixed by #93147
Labels
bug performance regression topic:editor
Milestone
4.3

Comments

@KoBeWi
Copy link
Member

KoBeWi commented Jun 12, 2024

Tested versions

Regression from #77932

System information

Windows 10.0.19045 - Vulkan (Forward+) - dedicated NVIDIA GeForce GTX 1060 (NVIDIA; 31.0.15.4633) - Intel(R) Core(TM) i7-7700HQ CPU @ 2.80GHz (8 Threads)

Issue description

I noticed that there is a noticeable editor freeze when saving a scene. I did some profiling and it turns out that when you save a scene, it causes EditorFileSystem update, which causes the FileSystem dock to... reload the whole tree.

While previously it wouldn't be that noticeble, it is after #77932.

Here's a comparison in a dev build.
With #77932

godot.windows.editor.dev.x86_64_tpRpT69keo.mp4

Without #77932

godot.windows.editor.dev.x86_64_nZFpWFZHIC.mp4

It's 3 times shorter. Maybe we wouldn't have freeze at all if the FileSystem dock did not decide to update for no reason.

Steps to reproduce

  1. Open a project with many resources (e.g. 2000)
  2. Save a scene

Minimal reproduction project (MRP)

N/A
@KoBeWi KoBeWi added this to the 4.3 milestone Jun 12, 2024
@CsloudX CsloudX mentioned this issue Jun 14, 2024
Closed
@Hilderin Hilderin mentioned this issue Jun 14, 2024
Merged
Hilderin added a commit to Hilderin/godot that referenced this issue Jun 20, 2024
@Hilderin
Fix Noticeable freeze after saving a scene godotengine#93104
8ac841a
fire pushed a commit to V-Sekai/godot that referenced this issue Jul 2, 2024
@Hilderin @fire
Fix Noticeable freeze after saving a scene godotengine#93104
8d44488
MewPurPur pushed a commit to MewPurPur/godot that referenced this issue Jul 11, 2024
@Hilderin @MewPurPur
Fix Noticeable freeze after saving a scene godotengine#93104
d59d4bc
sorascode pushed a commit to sorascode/godot-soras-version that referenced this issue Jul 22, 2024
@Hilderin @sorascode
Fix Noticeable freeze after saving a scene godotengine#93104
3e3f6b8
Luis-Wong pushed a commit to Luis-Wong/godot that referenced this issue Jul 26, 2024
@Hilderin @Luis-Wong
Fix Noticeable freeze after saving a scene godotengine#93104
a0d1c1c
2nafish117 pushed a commit to 2nafish117/godot that referenced this issue Aug 5, 2024
@Hilderin @2nafish117
Fix Noticeable freeze after saving a scene godotengine#93104
2b90169
chryan pushed a commit to chryan/godot that referenced this issue Aug 6, 2024
@Hilderin @chryan
Fix Noticeable freeze after saving a scene godotengine#93104
e542fbe
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug performance regression topic:editor
Projects
4.x Release Blockers
Status: Release Blocker
Milestone
4.3
Development

Successfully merging a pull request may close this issue.

Fix noticeable freeze after saving a scene Hilderin/godot
1 participant
@KoBeWi