Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[4.3] Fix various code examples in documentation #100686

Open
wants to merge 1 commit into
base: 4.3
Choose a base branch
from
Open

[4.3] Fix various code examples in documentation #100686

wants to merge 1 commit into from
+9 −9

Conversation

raulsntos
Copy link
Member

Backport of a few fixes I found in the docs while working on:

It's mostly changes to the C# examples, except for the changes to DTLSServer.xml that also touches the GDScript example.

The changes to DTLSServer.xml and Window.xml can be backported all the way to 4.0.

The changes to Array.xml only affect documentation that was introduced in 4.3.

@raulsntos raulsntos added this to the 4.3 milestone Dec 21, 2024
@raulsntos raulsntos requested a review from a team as a code owner December 21, 2024 02:42
Mickeon
Mickeon approved these changes Dec 21, 2024
View reviewed changes
Copy link
Contributor

@Mickeon Mickeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved for master branch so I don't see why not here too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mickeon Mickeon Mickeon approved these changes

@akien-mga akien-mga akien-mga approved these changes

Assignees
No one assigned
Labels
bug documentation topic:dotnet topic:gdscript
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.
3 participants
@raulsntos @akien-mga @Mickeon