Implement per-instance custom bounding box #12645
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
ghost
requested a review
from 
reduz
requested changes
Nov 20, 2017
| @@ -1015,6 +1015,9 @@ class VisualServerRaster : public VisualServer { | |||
| BIND3(instance_set_surface_material, RID, int, RID) | |||
| BIND2(instance_set_visible, RID, bool) | |||
|
|
|||
| BIND2(instance_set_custom_aabb, RID, Rect3) | |||
There was a problem hiding this comment.
I would just use a single function, and assume AABB() (empty bounding box) is disabled.
There was a problem hiding this comment.
Also needs a rebase since the re-rename from Rect3 to AABB.
# Conflicts: # servers/visual/visual_server_scene.h
|
Made it a single function and rebased |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows to set custom bounding box for
GeometryInstances. An example use case is when shader displacement is used, like with particles or heightmaps.Note: this PR only implements the feature on VisualServer API.
Fixes #9544
This is the first time I modify VisualServer, tell me if I did anything wrong.
Note: I see that Particles already have customizable AABB for the same reason, however it is stored in RasterizerStorageGLES3... should I remove it now?